exportable UI edit page needs to be in same tab group as other admin pages [#1179356]

Comment	File	Size	Author
#10	1179356.ctools.edit-not-in-tabs.patch	519 bytes	joachim

Comment #1

kylebrowning CreditAttribution: kylebrowning commented 7 June 2011 at 21:53

Status:

Active

» Closed (won't fix)

Unfortunately this a CTools thing.

Log in or register to post comments

Comment #2

joachim CreditAttribution: joachim commented 8 June 2011 at 06:10

Project:	Services	» Chaos Tool Suite (ctools)
Version:	7.x-3.x-dev	» 7.x-1.x-dev
Status:	Closed (won't fix)	» Active

Let's move it to CTools then, as it makes the UI pretty awkward to use.

Log in or register to post comments

Comment #3

merlinofchaos CreditAttribution: merlinofchaos commented 8 June 2011 at 15:39

I don't understand. What's wrong here?

Log in or register to post comments

Comment #4

joachim CreditAttribution: joachim commented 8 June 2011 at 16:01

The exportable thing, in this case a service, is using the CTools exportable UI AFAIK.

In the list of all things, there is a dropdown that says:

- edit
- resources
- authentication
- ... [others too]

The paths to do stuff with a particular thing are of this form:

- admin/structure/services/list/NAME/edit -- edit page
- admin/structure/services/list/NAME/resources -- resources settings page
- admin/structure/services/list/NAME/authentication -- authentication settings page

All of these sit in menu tabs so once you are on one, you can easily flip to the others. Except for the edit page, which has no tabs at all.

Log in or register to post comments

Comment #5

merlinofchaos CreditAttribution: merlinofchaos commented 8 June 2011 at 16:03

Strange. It's defined as the default local task:

    'edit' => array(
      'path' => 'list/%ctools_export_ui/edit',
      'title' => 'Edit',
      'page callback' => 'ctools_export_ui_switcher_page',
      'page arguments' => array($plugin['name'], 'edit', $prefix_count + 2),
      'load arguments' => array($plugin['name']),
      'access callback' => 'ctools_export_ui_task_access',
      'access arguments' => array($plugin['name'], 'edit', $prefix_count + 2),
      'type' => MENU_DEFAULT_LOCAL_TASK,
    ),

Log in or register to post comments

Comment #6

merlinofchaos CreditAttribution: merlinofchaos commented 8 June 2011 at 16:05

Maybe the issue is the %? If they don't match exactly, Drupal won't see them as being in the same tabset.

You can either change the % placeholder you're using, or define 'tab root' or 'tab parent' (I forget, it's kind of a weird system).

Log in or register to post comments

Comment #7

joachim CreditAttribution: joachim commented 8 June 2011 at 16:54

It's the edit page that seems to be at fault though. The others have a correct breadcrumb, whereas the edit page only has 'home'.

Interestingly, the menu_router table has entries with only % wildcards, not %ctools_export_ui as I expected, like this:

admin/structure/services/list/%/edit

All the other items get this as both their tab root and tab parent:

admin/structure/services/list/%

However, the edit page has the root set to itself, ie 'admin/structure/services/list/%/edit', but nothing for parent.

(BTW, probably another bug, but setting tab root or parent in the $plugin definition does not respect the menu prefix...)

Also, the type of the other items is 132, but for the edit page it's 0.

Log in or register to post comments

Comment #8

merlinofchaos CreditAttribution: merlinofchaos commented 8 June 2011 at 17:03

Are you running into the bug that Views ran into where the parentage can be set wrong because menu items get created when the schema is wrong? What happens if you clear the menu_links table for all 'services' links, then perform a menu rebuild? Does that fix the situation?

Also, the menu router table will omit the identifier from all % in the path, but that's still used (I think) when determining tab parentage. I'm...not actually sure I'm correct on that last part, though.

Log in or register to post comments

Comment #9

joachim CreditAttribution: joachim commented 8 June 2011 at 20:12

The problem seems to be this in ctools' export-ui.inc:

    'edit' => array(
      'path' => 'list/%ctools_export_ui/edit',
      'title' => 'Edit',
      'page callback' => 'ctools_export_ui_switcher_page',
      'page arguments' => array($plugin['name'], 'edit', $prefix_count + 2),
      'load arguments' => array($plugin['name']),
      'access callback' => 'ctools_export_ui_task_access',
      'access arguments' => array($plugin['name'], 'edit', $prefix_count + 2),
      'type' => MENU_CALLBACK, // callback?? hence never in the menu structure!
    ),

Log in or register to post comments

Comment #10

joachim CreditAttribution: joachim commented 8 June 2011 at 20:16

Status:

Active

» Needs review

File	Size
1179356.ctools.edit-not-in-tabs.patch	519 bytes

Here's a patch that fixes the problem in Services for me. The weight of -10 ensures the edit tab is the first, and gives implementing modules room to start their weights at 0.

Log in or register to post comments

Comment #11

joachim CreditAttribution: joachim commented 8 June 2011 at 20:16

Title:

service edit page needs to be in same tab group as other admin pages

» exportable UI edit page needs to be in same tab group as other admin pages

Log in or register to post comments

Comment #12

merlinofchaos CreditAttribution: merlinofchaos commented 8 June 2011 at 20:25

How come your paste in #9 does not match my paste in #5? It seems unlikely that I don't have the latest code...

Log in or register to post comments

Comment #13

joachim CreditAttribution: joachim commented 8 June 2011 at 20:33

It certainly does seem odd...

My git clone says:

~/Sites/7-drupal/sites/all/modules/ctools joachim$ git pull
Already up-to-date.
~/Sites/7-drupal/sites/all/modules/ctools joachim$ git st
# On branch 7.x-1.x
# Changed but not updated:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working directory)
#
#	modified:   includes/export-ui.inc
#
# Untracked files:
#   (use "git add <file>..." to include in what will be committed)
#
#	1102024.ctools.admin-list-empty-rows.patch
#	1102038-show-text-with-no-items.patch
#	1179356.ctools.edit-not-in-tabs.patch
no changes added to commit (use "git add" and/or "git commit -a")

(The diff of the modified file being what I just uploaded as a patch :)