In libraries 7.x-2.x-dev the libraries_get_path method return FALSE if the library wasn't found so the FirePHPCore is installed in DRUPAL_ROOT instead of sites/all/libraries path.

Attached a patch.

CommentFileSizeAuthor
#11 devel-1179094.patch2.43 KBjonhattan
#9 devel-1179094.patch1.02 KBjonhattan
#7 devel-1179094.patch2.67 KBjonhattan
#4 devel-1179094.patch2.67 KBjonhattan
devel.drush_.inc_.patch606 byteslucor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra’s picture

pcambra
he/him
Primary language Spanish
Location Asturies
CreditAttribution: pcambra commented
Issue tags: +develcontribute

Let's try to check this problem in the sprint

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Assigned: Unassigned » jonhattan
Status: Active » Needs work
jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Title: Drush integration devel-download wrong path download with libraries 7.x-2.x-dev » Drush integration devel-download wrong path download with libraries > 1.x
Version: 7.x-1.x-dev » 8.x-1.x-dev

Same problem with Drupal 8 - libraries 8.x-3.x

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs work » Needs review
FileSize
devel-1179094.patch2.67 KB

Since Drupal 8, the default path for contrib libraries is in the root folder (same for modules and themes), so the default location for FirePHP should be DRUPAL_ROOT/libraries instead of the devel folder. To this extent libraries module has nothing to do.

OTOH, libraries comes to the party if you want to place FirePHP at legacy sites/all/libraries, at sites/default/libraries or your profile's libraries folder. So libraries integration is only wanted if you are using one of those locations.

The fix for D7 is quite different, so if this patch gets accepted, it would need to be ported.

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Needs work

Committed. Thanks!

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs work » Patch (to be ported)

For drupal 7, the code must behave different depending on libraries.module version

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Priority: Normal » Major
Status: Patch (to be ported) » Needs review
FileSize
devel-1179094.patch2.67 KB

While working in the d7 version I realized the above patch has a flaw. We really need libraries module to check if FirePHP is already downloaded to any of the supported libraries locations!

Status: Needs review » Needs work

The last submitted patch, devel-1179094.patch, failed testing.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Needs work » Needs review
FileSize
devel-1179094.patch1.02 KB

Wrong patch file in #7

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Patch (to be ported)

Committed. Thanks!

Changed version to 7.x-1.x

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
CreditAttribution: jonhattan commented
Status: Patch (to be ported) » Needs review
FileSize
devel-1179094.patch2.43 KB

Here we go.

In Drupal 7 we still support FirePHP inside devel folder and also need to manage the API change between libraries 1.x and 2.x.

juampynr’s picture

juampynr CreditAttribution: juampynr commented
Status: Needs review » Fixed

Committed to 7.x-1.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.