Add checks to facetapi.js before applying link-type behavior to all facet blocks

I see what you are getting at. Could you further explain the "widgetFamily" to me? We already have the machine readable name of the widget. Couldn't we use that for the conditional?

Changing to a feature request because I think the functionality works as-is and I don't see it conflicting with future widgets. Obviously I could be missing something.

Looks good to me.

I think that makes sense. I want to try to get away from hard-coding the realms if possible. I created a task a while ago at #1147500: Improve the JavaScript API to remember to improve the JS API. I am even tpying with the idea of specifying the method or methods that are invoked per-facet in the jsSettings. For example:

$this->jsSettings['callbacks'] = array(
  'Drupal.facetapi.method1',
  'Drupal.facetapi.method2',
);

The methods would be out checkbox functionality or show more / show less stuff. That way we can eliminate any checks all together. Would like to hear thoughts on that approach.

How I see it, this would allow for different widgets to reuse the same settings. For example:

// For the "links" widget...
$this->jsSettings['callbacks'] = array(
  'Drupal.facetapi.applyLimit',
);

// For the "checkboxes" widget...
$this->jsSettings['callbacks'] = array(
  'Drupal.facetapi.makeCheckboxes',
  'Drupal.facetapi.applyLimit',
);

This way you could reuse settings without having to do the conditionals we have been working with. Also, as it stands every JS file associated with a widget has to iterate over the settings and do their own conditional to apply their own settings. Check out the for loop in the Chart Facets module's JS file. Defining the callbacks would eliminate the need for the widgets to loop through the settings in order to figure out which widgets should be acted on.

In what way? Are you concerned about the amount of data being transferred as JS settings, the actual $this->jsSettings variable getting too big and unwieldy, or something else I am not thinking of?

Awesome. Love the elimination of all that code. Moving the "callbacks" functionality to a post at #1147500: Improve the JavaScript API.