Filefield hardcodes default image, making impossible to change file system path and introducing data inconsistency [#1172704]

Filefield uses default image path that was initially configured so when filesystem path changes default image breaks.

Comment	File	Size	Author
#2	filefield_default_image_1172704.patch	883 bytes	crea

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

crea CreditAttribution: crea commented 30 May 2011 at 03:43

Title:

Filefield default image doesn't support changing file system path

» Filefield hardcodes default image, making impossible to change file system path and introducing data inconsistency

Actually, it's major source of inconsistency because (authoritative) information source (files table) is ignored.

Comment #2

crea CreditAttribution: crea commented 30 May 2011 at 03:56

Status:

Active

» Needs review

File	Size
filefield_default_image_1172704.patch	883 bytes

Comment #3

quicksketch

he/him

CreditAttribution: quicksketch commented 30 May 2011 at 18:02

Thanks, although changing the filesystem path is pretty difficult already and not recommended, there's no reason why we need to make that more difficult. Unfortunately this will add another query to every page load, which is why I'm guessing we didn't just use field_file_load() to begin with.

Comment #4

crea CreditAttribution: crea commented 31 May 2011 at 00:38

It's already possible to clone sites in Aegir, making sort of sandboxes, with filesystem path changing in the process. I never heard about it being not recommended. It's not user-friendly, sure, but definitely doable and not difficult.
This will add one perfectly optimized query (which should run in under 1ms) to page loads with default images. Since when we are afraid of making queries ?