Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I think it would be right if we change widget for Yes/No Checkbox. There should not be 2 checkboxes (Yes and No). There should be Label of field and then 1 checkbox. What you think about this?
Comment | File | Size | Author |
---|---|---|---|
#10 | yes-no-checkbox-1171952.patch | 3.78 KB | greggles |
#5 | yes-no-checkbox-1171952.patch | 3.78 KB | primerg |
Comments
Comment #1
NickWebman CreditAttribution: NickWebman commentedI agree
Comment #2
mikeker CreditAttribution: mikeker commentedAs do I, however it's difficult to tell a Boolean field element from a regular list field element when we're showing the BEF settings form. I'll look into it some more to see if I can find a way to do it...
Comment #3
NicolasH CreditAttribution: NicolasH commentedDid this ever go anywhere? Do people just form_alter their way around this?
Comment #4
Fidelix CreditAttribution: Fidelix commentedNicolasH, so far it's the only way... doing it yourself.
Comment #5
primerg CreditAttribution: primerg commentedAttached is a patch for D6. I'll create a patch for D7 once D6 is ok. Please review if the solution is ok.
one thing I do not still understand is the file better_exposed_filters_exposed_form_plugin.inc
How will I be able to test it?
Comment #7
primerg CreditAttribution: primerg commentedforgot to add the right version.
Comment #8
zmove CreditAttribution: zmove commentedSubscribe. I have several on/off checkbox. I just want a checkbox to enable the filter (checked) or disable it (not checked). Actually, I have 2 radios for each filter (Any, and the filter name) which is no user friendly.
Comment #9
greggles#5: yes-no-checkbox-1171952.patch queued for re-testing.
Comment #10
gregglesThe testing system seems to have become confused. Re-uploading the patch from #5 without any changes. All credit to primerg for the work, I'm just doing this to help testing...
Comment #11
mikeker CreditAttribution: mikeker commentedWrong version... Perhaps that's why the test-bot barfed?
Anyhow I'm reviewing the patch and testing by hand.
Comment #12
mikeker CreditAttribution: mikeker commentedFirst off, my apologies to all for letting this sit for so long... I had started on this feature request in 7.x and got bogged down by issues where the checked state wouldn't persist and let that get in the way of committing the 6.x patch.
@primerg: It looks like you were building the patch off the 2.0-beta release. It's always best to build from the latest -dev release or from a git clone of the repo. Regardless, thank you for the patch -- I've committed it to the 6.x-2.x branch.
Resetting to Needs Work for the 6.x-3.x and 7.x-3.x branches.
Comment #13
mikeker CreditAttribution: mikeker commentedre: #5: the better_exposed_filters_exposed_form_plugin.inc file. That file should not be in the 2.x release. I'm guessing that at some point you installed BEF 6.x-3.x and then overwrote it with 6.x-2.x? It's a good idea to delete the directory entirely before when coping a new version -- that way any directory/file changes don't leave leftover bits and pieces lying around.
Comment #14
mikeker CreditAttribution: mikeker commentedThis has been ported to the 7.x-3.x and 6.x-3.x branches. (The 6.x-3.x commit was later refined to remove options that are not available given the filter being edited).
Oddly, in Drupal 7, this option is not available for custom Boolean fields as those are implemented as ordinary list fields so, as far as I can tell, cannot be distinguished from other list fields. If that turns out to be incorrect, please reopen this issue and post a comment.