Recoverable fatal error when node form processed programmatically

Subscribe..........

Subscribing

Same error here.
emk

I think this issue is actually with Hierarchical Select.

NFC uses this code to grab the processed form elements (in function_nodeformcols_get_node_type_form):

  $fs = array(
    'build_info' => array('args' => array($node)),
  );
  $fs += form_state_defaults();
  $nf = drupal_retrieve_form($nfid, $fs);
  drupal_prepare_form($nfid, $nf, $fs);
  drupal_process_form($nfid, $nf, $fs);
  return $nf;

form_state_defaults() doesn't return a $form_state['input'], but Hierarchical Select depends on it for it's call to drupal_array_set_nested_value($form_state['input'], $element['#array_parents'], array()); (the line causing the fatal). The above seems like a pretty standard way of programmatically processing a form. I think it's a bit reckless to depend on something that isn't returned by form_state_defaults().

Wrapping it in an if statement fixes the issue with NFC for me, and should smooth over issues with any other modules that would use this method.

Attached is patch for the if wrap. If I'm wrong and this is a problem with NFC, the obvious fix is to add 'input' to the $fs array (untested):

  $fs = array(
    'build_info' => array('args' => array($node)),
    'input' => array(),
  );