Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
I've had me head in Panels for the last few months so I decided to take on UR's panels integration.
The attached is only a very rough start, there may be the need for a larger rewrite to make this work correctly with Panels 3.
Comments
Comment #1
mrf CreditAttribution: mrf commentedComment #3
BerdirNo idea what's wrong with the testbot...
Thinking about the name. I think we should start to standardize on user_relationship*s* as the module prefix, because that's the project name is and what the base module is called. And while most are the other way round right now, I think we shold name new modules correctly.
Does panels.module actually use this? Because files[] usually only has an effect if classes are inside that file and should only be used then.
Powered by Dreditor.
Comment #4
Shadlington CreditAttribution: Shadlington commentedSubbing
Comment #5
mrf CreditAttribution: mrf commentedUpdated the naming conventions for the panels submodule, and moved the implementation a little further along.
Visibility option is now loading as expected, but it still doesn't look like everything is working correctly.
Comment #7
Anonymous (not verified) CreditAttribution: Anonymous commentedsubscribe...
Comment #8
hedley CreditAttribution: hedley commentedCouple of small changes, the 'core' was set to 6.x and the $form wasn't being returned in the settings form.
This sub-module seems to work for me with those edits now.
Comment #9
BerdirWhy not use and test mrf's patch from #5?
Comment #10
mrf CreditAttribution: mrf commentedThe rename made this way to hard to evaluate, will do that as a separate step. I think this is almost there but I know there were bugs when I last looked at this.
Comment #12
mrf CreditAttribution: mrf commentedLeft in some of the remaining noise from the rename.
The missing $form return was keeping everything from working. As far as I can tell its working the same as d6 but would love some testing of this patch.
Comment #13
hedley CreditAttribution: hedley commentedThanks, was just figuring out what was going on with the other patches.
@Berdir - didn't realise those patches hadn't made it into dev
Will test this now
Comment #14
mrf CreditAttribution: mrf commentedForgot to mention that I posted #1469496: Rename user_relationships_panels_visibility to cover the renaming aspect.
Comment #15
hedley CreditAttribution: hedley commentedTested #12 and it is working well for me, using with the user profile page template.
One thing which I need is for the logged in user to be able to see the same thing when viewing their own profile as a user with a relationship can see. I've attached a patch which provides and option to do this, dependent on the patch in #12.
Comment #17
Berdir@hedley
Patches always need to contain all changes, partial patches are not supported by the testbot.
Please provide a combined patch and I'll commit this asap. I'm not currently using this submodule but we can deal with additional stuff later on once the initial port is commited.
Comment #18
hedley CreditAttribution: hedley commentedOk, still learning :) - here's a patch which combines #12 & #15
Comment #19
BerdirOk, commited and pushed. Thanks for working on this.