This is related to #789816: AddMaxMind PHP files to CVS.
Actually, lib files from MaxMind should be removed from the module and user himself should have to download them before install (possibly to /sites/all/libraries/geoip).
I know this complicates the installation process but this seems to be the right way to do.
See http://drupal.org/node/422996
and http://drupal.org/licensing/faq/#q10

If you wish to contribute a bridge module to a Drupal Git repository, please do not check in the 3rd party library itself. Doing so creates a fork of that 3rd party library, which makes it more difficult to maintain and only serves to waste disk space. Instead, provide detailed instructions for users to download and install that 3rd party library for use with your module.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

d.clarke’s picture

I've taken a first pass at this for D7 and then tried to back-port the patch to D6. The patch removes the library in question and replaces it with a libraries_load call from the libraries module. After applying the patch the user would just need to download the library from https://github.com/maxmind/geoip-api-php, extract the code to the sites/all/libraries directory, and then rename it to geoip.

There are three patch files included:

  • Remove_geoip_library_from_module_d6-1159090-1.patch - This should apply against the current D6 branch. This is untested.
  • Remove_geoip_library_from_module_d7-1159090-1.patch - This should apply against the current D7 branch. Since the D7 branch currently doesn't function, this patch is pretty useless and is untested.
  • Remove_geoip_library_from_module_d7_patched-1159090-1.patch - This should apply against the current D7 branch after applying the latest patch from #887268: Port GeoIP API to D7. This is tested and is working from what I can tell.

On a side note, this same issue appears to have been requested in #1307418: GeoIP Library is licensed under the terms of the LGPL

d.clarke’s picture

My patch file in comment 1 for the patched version of D7 didn't delete the old lib directory and files. The attached patch resolves that issue.

bojanz’s picture

Status: Needs review » Closed (outdated)