Can't add header or footer content to view [#1157716]

Hi, I'm getting this error when clicking "add" on the No Results Behavior. It happens on every view, including new ones.

Path: /admin/structure/views/ajax/add-item/quotes/book_quotes_pane/empty
StatusText: parsererror
ResponseText: Notice: Undefined index: area in views_ui_add_item_form() (line 4085 of C:\Inetpub\wwwroot\123.com\sites\all\modules\contrib\views\includes\admin.inc). =&gt;

It deals with this line of code:

views_ui_standard_form_buttons($form, $form_state, 'views_ui_add_item_form', t('Add and configure @types', array('@types' => $types[$type]['ltitle'])));

If I wrap that line in a if (isset($types[$type])) { then the ajax popup works, but has no "save" buttons. Sorry, I don't know how to debug this further, I have no clue.

Comment	File	Size	Author
#12	fixed-undefined-index-area-issue-1157716.patch	660 bytes	neoglez
#12

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 14 May 2011 at 17:33

Ok, I think the button simply lost its name.
If you check before line 4085 and add this

  if (!isset($types[$type])) {
    $types[$type]['ltitle'] = t('this');
  }

Then it works, but of course this is not the right approach. I dont know why that button lost its name

Comment #2

Anonymous (not verified) CreditAttribution: Anonymous commented 31 May 2011 at 11:07

This is still a bug in today's latest devx.

Comment #3

Anonymous (not verified) CreditAttribution: Anonymous commented 31 May 2011 at 11:07

Title:

Undefined index: area in views_ui_add_item_form() on line 4085

» Can't add header or footer content to view

Comment #4

neoglez CreditAttribution: neoglez commented 31 May 2011 at 21:30

Status:

Active

» Postponed (maintainer needs more info)

This is still a bug in today's latest devx.

I don't think so, not sure if it ever was a problem.
Are you using a contributed module that insert special JS in every page (for example by implemeting hook_init) or something like that??

Comment #5

magnusk CreditAttribution: magnusk commented 7 June 2011 at 20:50

Status:

Postponed (maintainer needs more info)

» Active

I get the same error message. Still, the footer I define does get added, and it does get displayed in the view.

I'm not using any such module that would insert special JS. There's no JS error in the web console (using Safari).

Comment #6

dawehner

German

CreditAttribution: dawehner commented 7 June 2011 at 21:02

Is it possible that someone can describe how to reproduce the problem.

Just some steps: a-f would really really help to fix the problem.

Comment #7

merlinofchaos CreditAttribution: merlinofchaos commented 10 June 2011 at 00:26

Status:

Active

» Postponed (maintainer needs more info)

Unable to reproduce, as are others. Clearly there is something different about your system. Not sure what, but can you try this on a fresh install?

Comment #8

David Sparks CreditAttribution: David Sparks commented 29 June 2011 at 04:04

I'm getting the same error with the current views-7.x-3.x-dev. The error only appears with JS switched off, or the devel module enabled. Otherwise the undefined index is still encountered ($types['area'] does not exist), but it doesn't prevent the ajax call from completing successfully.

The cause is on line 3855 of includes/admin.inc, when processing the 'header' and 'footer' views object types, both of which have 'type' => 'area' set. Hence !empty($types[$type]['type']) results in $type being reset to 'area', but $types does not contain an 'area' key so $types[$type] on line 3950 gives the undefined index warning.

Should there be an 'area' views object type? That seems to be what is expected - if a views object type has a 'type' then that 'type' should also be a views object type. The 'header' and 'footer' object types both have 'type' set to 'area' in views_object_types().

Comment #9

neoglez CreditAttribution: neoglez commented 29 June 2011 at 07:27

Assigned:	Unassigned	» neoglez
Status:	Postponed (maintainer needs more info)	» Active

@ David Sparks you're right.
Please see #8 in #1190510: Missing 'aliases' key definition in views_views_data
and the patch posted in #9 in the same issue.
I have to bring the patch down here ;)

Comment #10

willieseabrook CreditAttribution: willieseabrook commented 30 June 2011 at 16:20

I am getting this error on views 7.x-3.0-rc1

Steps to reproduce are to:

1. Enable devel module
2. /admin/config/development/devel --> set error handler to backtrace
3. Create a new view.
4. Click 'add' under header text. Error dialog pops up with a bunch of krumo stuff.

With devel disabled, I can add header text fine - no error. So I guess this is a minor issue, as it doesnt hinder the normal user, and there is a simple workaround.

But its also probably not good having invalid indexes used as that means something is wrong.

Also, I tried the patches in #1190510: Missing 'aliases' key definition in views_views_data suggested by @neoglez, but they didn't fix the issue.