Support of Tabs | Vertical Tabs & Multistep [#1153166]

Hello, I have a simi-complicated form that is using Vertical Tab styling and the Multistep module. On each step I have several fieldgroups exposed as tabs. In the fieldgroups there are required fields.

If I click on next, to go to the next step in the form, require fields from the currently displayed tab are highlighted/validated. But the required fields from tabs that are not currently displayed, are not validated.

Maybe this behavior is by design and should be categorized as a feature request.

thanks, tom

Comment	File	Size	Author
#7	vertical_tabs_support-1153166-7.patch	3.12 KB	mjpa
#7
#4	hidden_elements-1153166-4.patch	2.46 KB	mjpa
#4

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

attiks CreditAttribution: attiks commented 11 May 2011 at 07:51

Category:

bug

» feature

this is by design, only visible fields are checked

Comment #2

tomdavidson CreditAttribution: tomdavidson commented 11 May 2011 at 17:20

Makes sense. Perhaps the feature request should be with multi-step to step through tabs, but that doesn't seem to quite fit either.
Thanks

Comment #3

attiks CreditAttribution: attiks commented 27 July 2011 at 21:03

Status:

Active

» Closed (works as designed)

Comment #4

mjpa CreditAttribution: mjpa commented 1 August 2011 at 11:15

Status:

Closed (works as designed)

» Needs review

File	Size
hidden_elements-1153166-4.patch	2.46 KB

Rather than closing a feature request issue, it'd be nice if the feature request was implemented.

I've included a patch to add a textarea to the admin page that allows you to specify the form IDs that should have hidden elements validated, if a form ID isn't listed then it'll keep the current behaviour - that is hidden elements will be ignored.

Comment #5

attiks CreditAttribution: attiks commented 1 August 2011 at 11:49

Assigned:

Unassigned

» Jelle_S

@mjpa, thanks for the patch, we'll try to implement it asap

Comment #6

Jelle_S

Dutch

Antwerp, Belgium

CreditAttribution: Jelle_S commented 1 August 2011 at 12:45

Status:

Needs review

» Fixed

patch tested added to both dev branches, thanks mjpa

Comment #7

mjpa CreditAttribution: mjpa commented 1 August 2011 at 15:47

Version:	6.x-1.x-dev	» 7.x-1.x-dev
Status:	Fixed	» Needs review

File	Size
vertical_tabs_support-1153166-7.patch	3.12 KB

Should probably have included these changes with the original patch but thought they could be done outside of this module. Turns out it's not that easy... so here's another patch. The patch basically does the following 2 things:

1. Adds the error/valid classes to the actual tabs so a user can tell that a tab has errors inside it.
2. Sets focus to the first tab with errors, unless the current tab itself has errors.

Comment #8

Jelle_S

Dutch

Antwerp, Belgium

CreditAttribution: Jelle_S commented 2 August 2011 at 10:12

patch committed to the dev branch.
I also added an other setting to validate all input fields of vertical tabs (even the hidden ones) as standard, people can disable it if they want to. All other hidden fields are ignored.