Simple fix here, turn two columns into one.

Slightly complicated because it looks like we've implemented these floats using unsemantic css classes.

Best do this right and rewrite the markup for semantic mark up + media queries.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

LewisNyman’s picture

JohnAlbin’s picture

Issue tags: +mobile

This is for pages like the admin/configuration landing page. We should document all of those pages and make sure they are all built very similarly, preferably with the exact same classes.

jefflinwood’s picture

I'm happy to do this, but I don't want to step all over work that's already been done. Has anyone gone through and done an audit core's admin panels?

LewisNyman’s picture

I've gone through the code. It's a right mess. The html output ends up being a "left" and a "right" div split in two.

We need to kill that and output a basic unordered list.

JohnAlbin’s picture

Over in #1137782: Remove unused CSS in Seven theme that uses desktop-sized layouts, Jeff Linwood says:

Specifically, the CSS in Seven's style.css that should change along with screen width is Lines 734-752:

/**
 * System.
 */
div.admin .right,
div.admin .left {
  width: 49%;
  margin: 0;
}
div.admin-panel,
div.admin-panel .body {
  padding: 0;
  clear: left;
}
div.admin-panel {
  margin: 0 0 20px;
  padding: 9px;
  background: #f8f8f8;
  border: 1px solid #ccc;
}

That said, it's my recommendation that we look at a semantic way of describing this output.

I think that comment will help move this issue along.

dcmouyard’s picture

Assigned: LewisNyman » dcmouyard
Issue tags: +sprint

I'll be working on a patch for this.

dcmouyard’s picture

Here's a first stab at this issue. I prefer to use em values in media queries, so I set the breakpoint at 40em.

dcmouyard’s picture

Status: Active » Needs review

Marking as needs review.

dcmouyard’s picture

Forgot to edit the rtl stylesheet in the last patch...

LewisNyman’s picture

The patch works in the browser at a 640px breakpoint.

I'd be happy to approve this but I am unable to test this on mobile devices because they simulate a 960px viewport. This issue is now reliant on: #1468582: Add mobile friendly meta tags to the html.tpl.php

nod_’s picture

Status: Needs review » Needs work

works for me, but it looks like it needs a reroll.

nod_’s picture

Status: Needs work » Needs review
FileSize
2.12 KB

Here it is.

alanburke’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
81.51 KB

This is a good improvement.
Tested with Chrome .
admin-responsive.png

yoroy’s picture

This patch is a Good Thing.

catch’s picture

Status: Reviewed & tested by the community » Fixed

Makes sense. Committed/pushed to 8.x.

JohnAlbin’s picture

Component: Stark theme » Seven theme

Nice work!

Automatically closed -- issue fixed for 2 weeks with no activity.