Motivation:
I use BEF to expose some filters as "hidden" fields, and I manually build links to the filters i want to expose.

Problem:
The "Apply" button still appears, even though there are no visible filters to apply.

Solution:
If all exposed filters are "hidden", then hide the "Apply" button as well.

Filing this as a bug, but it's arguably a feature request.
Patch forthcoming.

CommentFileSizeAuthor
#9 Apply button still there.png1.83 KBpal4life
#1 bef-6.x-1.0-hide-submit-1149254.patch1.53 KBAaronBauman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AaronBauman’s picture

AaronBauman
he/him
CreditAttribution: AaronBauman commented
Assigned: AaronBauman » Unassigned
Status: Active » Needs review
FileSize
bef-6.x-1.0-hide-submit-1149254.patch1.53 KB

This patch is rolled against 1.0, but applies cleanly (with offset) against dev.

mikeker’s picture

mikeker CreditAttribution: mikeker commented
Status: Needs review » Fixed
Issue tags: +needs forward port to Drupal 7

A slightly changed version has been committed. Thanks for the patch!

This fixes the issue on D6 for Views 2.x and 3.x, but needs to be ported to D7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

mikeker’s picture

mikeker CreditAttribution: mikeker commented
Status: Closed (fixed) » Needs work

Whoops... Should've left it at needs work as it still needs a D7 forward port.

mikeker’s picture

mikeker CreditAttribution: mikeker commented
Status: Needs work » Fixed

Committed to the 7.x branch.

Now I can mark it as fixed...

heivoll’s picture

heivoll CreditAttribution: heivoll commented

Shouldn't the same also be true for when all filters are displayed as links, or links + hidden?

Automatically closed -- issue fixed for 2 weeks with no activity.

pal4life’s picture

pal4life CreditAttribution: pal4life commented
Version: 6.x-1.x-dev » 7.x-3.0-beta4
Issue summary: View changes
Status: Closed (fixed) » Active

This is an issues in D7.
So opening this again.

I selected the Better Exposed Filter setting for my exposed filter to Hidden. It hid the field but the apply button is still there.

pal4life’s picture

pal4life CreditAttribution: pal4life commented
FileSize
Apply button still there.png1.83 KB

The lone apply button.

mikeker’s picture

mikeker CreditAttribution: mikeker commented
Status: Active » Closed (duplicate)

Issue queue cleanup... My apologies for taking so long to address this issue!

I believe this is fixed with the code committed in #1446962: hide the form submit button if all filters are links. Please reopen if that is not the case.

Thanks.

mikeker’s picture

mikeker CreditAttribution: mikeker commented
Issue tags: -needs forward port to Drupal 7