In /misc/ajax.js, line 132, Drupal.ajax does this.url = element_settings.url.replace(/\/nojs(\/|$|\?|&|#)/g, '/ajax$1');

Except in Views js/ajax.js, Drupal.behaviors.viewsAjax only passes the URL in certain cases, causing strange problems.

CommentFileSizeAuthor
#4 views-1141410-4.patch1.25 KBtim.plunkett
#3 views-1141410-3.patch1.19 KBtim.plunkett
#2 views-1141410-2.patch763 bytestim.plunkett
#1 views-1141410-1.patch368 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new views-1141410-1.patch368 bytes

My JS is not very good, so I'm not sure that this is the proper way to fix this, but this patch solves the problem.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1141410-2.patch763 bytes

I'm seeing this when using FullCalendar, which contains JS links, ones without an href.

This makes more sense now, since it will return unless there is an href that matches 'admin/structure/views', which is the whole point.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1141410-3.patch1.19 KB

Learning new approaches to control structures. Always cool.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1141410-4.patch1.25 KB

Now with improved whitespace and a comment!

merlinofchaos’s picture

merlinofchaos commented
Priority: Normal » Major
Status: Needs review » Reviewed & tested by the community

Looks good now. Marking RTBC since I'm not in my Views repo right now. we'll see who gets to this first, me or dereine.

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Makes makes really sense. Commited to 7.x-3.x

Is a backport needed?

dawehner’s picture

dawehner
Primary language German
commented
Status: Patch (to be ported) » Fixed

No backport is needed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.