drupal_add_feed allows feeds to be added multiple times in header but not in content [#112374]

drupal_add_feed:

1. adds the feed URL into a static map variable
2. also immediately calls drupal_add_link (which then immediately calls drupal_set_html_head)

These two actions are redundant, and the design of the function (and themes) should be rearranged such that one of the two actions is removed.

If drupal_set_html_head is called immediately, it isn't useful to store the URL map. It's too late to remove the link from the page, and the implementation of the map doesn't even make much sense. Consider the case where drupal_add_feed is called twice with the same URL.

If the map is to be stored, we shouldn't call drupal_set_html_head. Instead, the map should be output and formatted in the theme. That gives us the chance to remove items in the theme if we choose, and has the added benefit that it won't be possible to output the same RSS feed more than once on the same page.

Comment	File	Size	Author
#3	112374.patch	485 bytes	Wesley Tanaka
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Wesley Tanaka CreditAttribution: Wesley Tanaka commented 24 January 2007 at 15:45

It seems that these two actions are for two separate purposes. The static map is used to produce the list of feed links in theme_page, and the header is generated with the call to drupal_add_link

It seems like it would be much cleaner to have both outputs generated from the same map.

Comment #2

Wesley Tanaka CreditAttribution: Wesley Tanaka commented 24 January 2007 at 15:53

Title:

drupal_add_feed does two redundant things

» drupal_add_feed allows feeds to be added multiple times in header but not in content

It seems like javascript is also still handled in this "append strings" fashion, and that doing something along the lines of #1 would possibly break compatibility with 5.0 themes.

Changing the scope of the issue