Strict warning: Creating default object from empty value in maestro_reviewContentType() (line 62 of C:\Inetpub\wwwroot\xampp\htdocs\myREPLife\sites\all\modules\contrib\maestro\modules\maestro_content_publish\maestro_content_publish.module).

I have identified line 62 for you

Any ideas?

Here is the current maestro_reviewContentType() from maestro_content_publish.module. This is straight from version 7.1.1 and is unmodified:

function maestro_reviewContentType($op,&$task,$parms) {
global $base_url;

$nid = maestro_getNodeId($task->_properties->process_id,$parms['content_type']);

if ($nid === FALSE) {
LINE 62: $retval->retcode = FALSE;
return $retval;
}

$node = node_load($nid);
if ($node === FALSE) {
$retval->retcode = TRUE;
$retval->html = t('Invalid Node: Content possibly has been deleted.');
return $retval;
}
$retval = new stdClass();
$retval->html = '';
$retval->retcode = FALSE;
$retval->engineop = ''; // Optionally set the engineop value if you want to complete the task

switch ($op) {
case 'display':
$data = $task->getTempData();
$retval->html = theme('maestro_content_publish_review',array(
'nid' => $nid,
'queue_id' => $task->_properties->queue_id,
'title' => $node->title,
'data' => $data));

$retval->retcode = TRUE;
$retval->engineop = '';
break;
case 'complete':
$data = $task->getTempData();
$tracking_id = maestro_getTaskTrackingId($task->_properties->queue_id);
if (empty($data['reviewstatus']) AND !isset($_POST['reviewstatus'])) {
$retval->retcode = FALSE;

} elseif ($data['reviewstatus'] == 'accept' OR $_POST['reviewstatus'] == 'yes') {
$data['reviewstatus'] = 'accept';
$task->saveTempData($data);
$retval->retcode = TRUE;
$retval->status = MaestroTaskStatusCodes::STATUS_COMPLETE;
$retval->engineop = 'completetask';
// Flag the content record as accepted
db_update('maestro_project_content')
->fields(array( 'status' => MaestroContentStatusCodes::STATUS_UNDER_REVIEW))
->condition('tracking_id', $tracking_id)
->condition('nid', $nid)
->execute();

} elseif ($data['reviewstatus'] == 'reject' OR $_POST['reviewstatus'] == 'no') {
$data['reviewstatus'] = 'reject';
$task->saveTempData($data);
$retval->retcode = TRUE;
$retval->status = MaestroTaskStatusCodes::STATUS_IF_CONDITION_FALSE;
$retval->engineop = 'completetask';
// Flag the content record as rejected
db_update('maestro_project_content')
->fields(array( 'status' => MaestroContentStatusCodes::STATUS_REJECTED))
->condition('tracking_id', $tracking_id)
->condition('nid', $nid)
->execute();

} else {
$retval->retcode = FALSE;
}
break;
case 'update':
if($_POST['reviewstatus'] == 'yes') {
$data['reviewstatus'] = 'accept';
$task->saveTempData($data);
} elseif ($_POST['reviewstatus'] == 'no') {
$data['reviewstatus'] = 'reject';
$task->saveTempData($data);
}
$retval->retcode = TRUE;
break;
}

return $retval;

}

Comments

_randy’s picture

Status: Active » Needs review

Pushed a fix for this to the dev branch. It's simple enough, but still needs review.

Wallace123455’s picture

thanks

_randy’s picture

Status: Needs review » Closed (fixed)

  • Commit eed5a0f on master, 8.x-1.x:
    Issue #1121596, submitted by Wallace123455, strict error being thrown....