Hi, testing the content access rules integration I've found a minor bug.

On content_access.rules.inc, function content_access_list_to_checkboxes() calls _content_access_get_operations_lables($operations) which doesn't exists.

A simple fix would be to remove that call:

  $labels = _content_access_get_operations_lables($operations);

and change the line:

    $checkboxes[$op]['#title'] = t($labels[$op]);

to:

    $checkboxes[$op]['#title'] = t($op);

Thanks for the attention.

Files: 
CommentFileSizeAuthor
#1 fix-labels-1110860-1.patch736 byteseosrei
PASSED: [[SimpleTest]]: [MySQL] 32,291 pass(es).
[ View ]

Comments

eosrei’s picture

Status:Active» Needs review
StatusFileSize
new736 bytes
PASSED: [[SimpleTest]]: [MySQL] 32,291 pass(es).
[ View ]

Patch for this change attached.

Status:Needs review» Needs work

The last submitted patch, fix-labels-1110860-1.patch, failed testing.

BenK’s picture

Subscribing

good_man’s picture

good_man’s picture

Status:Needs work» Needs review

#1: fix-labels-1110860-1.patch queued for re-testing.

good_man’s picture

Status:Needs review» Fixed

Committed thanks a lot, hope we can finish Rules integration soon.

Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.