dummyimage's imagecache hooks can interfere with chaining [#1102112]

The README.txt notes that dummyimage takes over imagecache's theming function and can't be overridden. The attached patch fixes this.

Comment	File	Size	Author
#3	dummyimage_smarter_chaining.patch	1.76 KB	cotto
#1	dummyimage_smarter_chaining.patch	1.79 KB	cotto
	dummyimage_smarter_chaining.patch	1.98 KB	cotto

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

cotto CreditAttribution: cotto commented 22 March 2011 at 23:53

File	Size
dummyimage_smarter_chaining.patch	1.79 KB

same patch without extra git junk at the top

Comment #2

naxoc CreditAttribution: naxoc commented 23 March 2011 at 20:16

Status:

Needs review

» Active

Does this patch require that the module depends on the imageinfo_cache module? I had to google the IMAGEINFO_CACHE_THEME_IMAGECACHE_CALLBACK constant, and the only place I could find it was in that module.

Comment #3

cotto CreditAttribution: cotto commented 24 March 2011 at 00:09

File	Size
dummyimage_smarter_chaining.patch	1.76 KB

I had copy/pasted the code from imageinfo cache and didn't notice that constant, long and capitalized as it was. Using a hard-coded default for that variable is fine and ends up making the patch easier to understand. An updated patch without the constant is attached.