message type hook instead of serializing arguments [#1099130]

I've just reviewed message_example and i was surprised that message serializes the callback message by message.

Why not defining a message type using a hook and defining callbacks per message type?
You're storing much information (messages are heavy, consume too much storage) that actually is also ugly to migrate once a module changes architecture / callbacks.

Regarding design there should be things like hook_message_info and more.

Did you change this in 7.x? Any plans to make cleaner types?

Comments

Comment #1

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 20 March 2011 at 11:47

> Did you change this in 7.x? Any plans to make cleaner types?

Indeed, this was reworked in 7.x, as Entity API doesn't exist in 6 :/
And indeed, upgrade path isn't easily possible, because of the different approach.

Comment #2

Grayside CreditAttribution: Grayside commented 21 March 2011 at 17:28

Yeah, not looking forward to that. I suspect the upgrade path is going to look like a conceptual document. Probably one I'll end up writing up when I need to switch over ;(

Comment #3

amitaibu

Hebrew

Israel

CreditAttribution: amitaibu commented 21 March 2011 at 19:37

@Grayside,
I'm working on og-migrate module now days. I think much of its ideas/ code could be borrowed to help with an upgrade script. But yeah, it going to hurt a bit ;)

Comment #4

Grayside CreditAttribution: Grayside commented 25 March 2011 at 17:48

@miro_dietiker did you have an idea about how to handle storage per message in a scalable way without the serialization or entities?

~~I'm not sure if it's worth~~ It's almost certainly not worth swapping out part of the backbone for D6 when D7 has already been a dramatic, corrective rewrite.