Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
17 Mar 2011 at 20:58 UTC
Updated:
3 Jan 2014 at 02:58 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dawehnerThis is a valuable task
Comment #2
manuel garcia commentedHere's a working patch against 6.x-3.x
Enabling views:
drush views-enable frontpagedrush ven frontpage taxonomy_termDisabling views:
drush views-disable frontpagedrush vdis frontpage taxonomy_termComment #3
dawehnerI'm sorry but this patch does not apply anymore, because recently a views analyze command was added.
In general the code looks fine but in d7 we could perhaps use some ctools functions to enable/disable a view. There is one
Comment #4
chx commentedA quick grep makes me think views_defaults is gone and testModuleTemplates fails as well.
Comment #5
dawehner@chx
Was this comment related to this issue?
In general there is already an issue about testModuleTemplates.
Comment #6
chx commentedThe patch runs + variable_set('views_defaults', $views_status); and so my comment was meant for this issue -- but it's only gone in 7.x sorry i confused my trees :)
Comment #7
dawehnerOh i recognized this as well: http://drupal.org/node/1096652#comment-4684470 ... facepalm ...
Comment #8
manuel garcia commentedHere's an updated patch, should apply fine against 6.x-3.x
was too lazy to use format-patch though ... :X
Comment #9
merlinofchaos commenteddelimited is misspelled.
Comment #10
manuel garcia commentedVery true, misspelled differently in 4 places...
Here's an updated patch.
Comment #11
dawehnerOh i missed to see the patch
Did some manual testing and it worked fine.
The review also passed so commited to 6.x-3.x and 7.x-3.x.
Thanks!! for working on that, i really like it.
Comment #12
andypostExample for disable is wrong
Comment #13
dawehnerThanks!
Comment #14
manuel garcia commentedawesome!
oops! @andypost good catch!