Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi Rob,
I just had a good look through the D7 branch - looks good! Nice and simple to set up. It also works, which is always a bonus!
I posted a couple of other little issues (with patches) but in the course of looking through I (or my IDE!) made a bunch of little coding standards/white space/tab issues and little documentation changes.
I figured I'd just bundle them up here and let you do with them what you will.
Comment | File | Size | Author |
---|---|---|---|
#1 | simpleshare_coding_style_1096438_1.patch | 8.73 KB | stevetweeddale |
Comments
Comment #1
stevetweeddale CreditAttribution: stevetweeddale commentedThe only thing that's even a little interesting here is the removal of the files[] declarations in your info - they only have a use for dynamic loading of classes and interfaces I believe, so aren't needed here.
I should also note that I've just been told the --no-prefix argument I used making those other patches may cause problems...let me know if you run into issues.
Comment #2
Rob_Feature CreditAttribution: Rob_Feature commentedThis and the other patches rolled into dev. Thanks!