Hi Rob,

I just had a good look through the D7 branch - looks good! Nice and simple to set up. It also works, which is always a bonus!

I posted a couple of other little issues (with patches) but in the course of looking through I (or my IDE!) made a bunch of little coding standards/white space/tab issues and little documentation changes.

I figured I'd just bundle them up here and let you do with them what you will.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stevetweeddale’s picture

The only thing that's even a little interesting here is the removal of the files[] declarations in your info - they only have a use for dynamic loading of classes and interfaces I believe, so aren't needed here.

I should also note that I've just been told the --no-prefix argument I used making those other patches may cause problems...let me know if you run into issues.

Rob_Feature’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Active » Fixed

This and the other patches rolled into dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.