I get the following warnings, but only when my view contains the problematic fields as I described in #1087898: PDOException: SQLSTATE[HY000] on batch export.
Notice: Undefined variable: header in template_preprocess_views_data_export_msoffice_header() (line 290 of theme/views_data_export.theme.inc).
Notice: Undefined variable: output in template_preprocess_views_data_export_msoffice_body() (line 255 of theme/views_data_export.theme.inc).
Notice: Undefined variable: header in template_preprocess_views_data_export_msoffice_body() (line 258 of theme/views_data_export.theme.inc).

Attached patch fixes these warnings (tablesort-functions were not called properly).
The patch does away with the warnings, but is no remedy to the other issue. (That's why I open this new post.)

CommentFileSizeAuthor
#5 views_data_export-1088990-5-Fix_pesky_notices.patch2.15 KBnickl
vde_template_preprocess_views_data_export_msoffice.patch1.13 KBjohnv

Comments

steven jones’s picture

steven jones commented
Priority: Normal » Critical
steven jones’s picture

steven jones commented

Fixed in git, thanks for the patch!

steven jones’s picture

steven jones commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nickl’s picture

nickl commented
Version: 7.x-3.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new views_data_export-1088990-5-Fix_pesky_notices.patch2.15 KB

Fix those pesky NOTICES patch against 6.x-2.x HEAD.

steven jones’s picture

steven jones commented
Status: Needs review » Needs work 
+++ b/theme/views_data_export.theme.inc
@@ -259,13 +259,15 @@ function template_preprocess_views_data_export_msoffice_body(&$vars) {
-  $ts = tablesort_init($vars['header']);
+  $header = array($vars['header']);
+  $ts = tablesort_init($header);

I don't get why you're adding a wrapping array here, we shouldn't need it according to the docs.

steven jones’s picture

steven jones commented
Status: Needs work » Fixed

I think I can see what's going on there, fixed in 6.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.