Issue #682888: $classes for views-view.tpl.php introduced in views-6.x-2.9 in template_preprocess_views_view() the following:

  // Basic classes
  $vars['classes_array'] = array();
  $vars['classes_array'][] = 'view';
  $vars['classes_array'][] = 'view-' . views_css_safe($vars['name']);
  $vars['classes_array'][] = 'view-id-' . $vars['name'];
  $vars['classes_array'][] = 'view-display-id-' . $vars['display_id'];

based on zen itself, making most of zen_preprocess_views_view() redundant.
Attached patch removes duplicates, but preserves functionality for views older than 2.9, maybe they should be removed altogether ?


JohnAlbin’s picture

Title:redundant views classes » Views classes redundant since Views 6.x-2.9
Status:Needs review» Fixed


What's the likelihood that a site would update to Zen 6.x-2.1, but not update to one of the 3 security releases of Views since 6.x-2.8? :-\

Let's just nix the whole zen_preprocess_views_view() function.


Status:Fixed» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

joachim’s picture

Status:Closed (fixed)» Active

In that case, shouldn't views-view.tpl.php be removed also?

barraponto’s picture

Status:Active» Needs review
new2.95 KB

There is no difference between our tpl.php and the one mantained by views. I'm removing the file as theming will get easier if we just inherit the template from views.

JohnAlbin’s picture

Component:CSS/HTML markup» layout.css
Status:Needs review» Closed (fixed)

we're in bug fix mode now in 6.x-2.x branch. The tpl has been removed in the d7 versions.