Because strstr() is faster than ereg(), it should be used for some validity checking in user.module.

CommentFileSizeAuthor
#2 user.module_66.patch1.43 KBmeba
user.module_65.patch1.41 KBmeba
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Active » Needs work

strpos() would be *even* faster in those cases.

meba’s picture

meba CreditAttribution: meba commented
Title: strstr() is faster than ereg() in user.module » strpos() is faster than ereg() in user.module
FileSize
user.module_66.patch1.43 KB

You are right, rerolling.

m3avrck’s picture

m3avrck CreditAttribution: m3avrck commented
Status: Needs work » Reviewed & tested by the community

Looks good now!

Steven’s picture

Steven CreditAttribution: Steven commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)