There's no need to have any of module files in files[] section because they contain no classes

CommentFileSizeAuthor
#4 1075946-4.patch2.91 KBamateescu
#2 1075946.patch3.87 KBamateescu
#1 1075946-infofile.patch704 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Active » Needs review
FileSize
1075946-infofile.patch704 bytes

My first patch with git...

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Title: Cleanup .info file » General module cleanup
FileSize
1075946.patch3.87 KB

I think transliteration.inc should stay in the .info file. Here's a revised patch that also includes some Coder fixes.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Needs work 
+++ b/transliteration.admin.incundefined
@@ -47,7 +47,7 @@ function transliteration_retroactive() {
-  return confirm_form($form, $question, 'admin/config/media/file-system/settings', $description, t('Transliterate'));
+  return confirm_form($form, $question, 'admin/config/media/file-system/settings', filter_xss($description), t('Transliterate'));

description already cleean

+++ b/transliteration.infoundefined
@@ -2,7 +2,4 @@ name = Transliteration
 files[] = transliteration.inc

no need because there's no classes or interfaces, see http://drupal.org/node/542202#files

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Needs work » Needs review
FileSize
1075946-4.patch2.91 KB

1. just wanted to keep Coder happy, reverted that change.
2. fair enough :)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

Great!

amateescu’s picture

amateescu CreditAttribution: amateescu commented
Status: Reviewed & tested by the community » Fixed

Commited #4 to 7.x-3.x. Thanks @andypost :)

http://drupalcode.org/project/transliteration.git/commit/9767861

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.