Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
1.64 KB
tim.plunkett’s picture

Here's a better one.

aspilicious’s picture

Ok great, I always wondered why we needed the parent options.

general question
----------------

+  // Field API date fields.
+  foreach (field_info_fields() as $id => $field) {
+    if (in_array($field['type'], array('date', 'datestamp', 'datetime'))) {
+      $data['field_data_' . $id][$id]['field']['handler'] = 'fullcalendar_handler_field_field';

This code will find ALL the date fields in our system even if we don't need them?
Will this not affect performance?

EDIT:
And what will happen if you have a date field not added to the view. That field would not be a part of $data I guess. So $data['field_data_' . $id][$id]['field']['handler'] doesn't exist and it will throw errors?

tim.plunkett’s picture

hook_views_data_alter runs only when the view cache is cleared, and it loops through EVERY possible field on a site. So, no problem, and not a real performance issue.

tim.plunkett’s picture

Priority: Normal » Major
aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

After some serious brain dead testing I'm positive about the fact that this patch is working :).

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.