I'm using site-verify with an installation profile, and it'd be nice to have API functions to add new verifications.

This would require refactoring of the queries that record the verifications from the form-submit handlers:

drupal_write_record('site_verify', $form_state['values'], array('svid'));

and moving those into API functions.

CommentFileSizeAuthor
#2 site_verify-1059798-use_API_functions.patch10.9 KBmanarth
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Yeah definitely. Going to add it after the 1.0 version.

manarth’s picture

manarth CreditAttribution: manarth commented
Status: Active » Needs review
FileSize
site_verify-1059798-use_API_functions.patch10.9 KB

Here's a patch based on head.

The 2 new API functions are:
- site_verify_save($verification);
- site_verify_delete($svid);

The form handlers use the API functions, and there are a few new code-comments.

joachim’s picture

joachim CreditAttribution: joachim commented
Issue summary: View changes
Status: Needs review » Needs work

Patch has a lot of unrelated changes, some of which look like they would have been part of a D7 upgrade.

joachim’s picture

joachim CreditAttribution: joachim commented

It also no longer applies cleanly...

However, the patch contains has a lot of documentation improvements, which I'll commit now, as these are always a good thing. Thanks!

git commit -m "by manarth: Fixed missing function documentation; added comments to code." --author="manarth "

Commit b9f12c18835398e92896b7c81c40f250b4985055.