In lib/geoipcity.inc, the function geopip_record_by_address is spelled "GeoIP_record_by_addr", which is inconsistent with its use the module code, where "geoip_record_by_addr" is called. This bit me as I was grepping through the source for the definition of this function to understand how geoip handles data internally.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

Status: Active » Needs work

I actually think we should avoid changing the upstream code and instead correct out calls to it.

drewish’s picture

Oh I see what you're saying, we're using the same name they use to call it... I'd probably be okay with this then.

drewish’s picture

Status: Needs work » Needs review
Aanal.addweb’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
FileSize
4.47 KB
4.5 KB

@drewish, Thanks for the patch it works well As I tested it by applying it manually in module file and it updates the required change. PFA

bojanz’s picture

Status: Reviewed & tested by the community » Closed (outdated)