Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
In lib/geoipcity.inc, the function geopip_record_by_address is spelled "GeoIP_record_by_addr", which is inconsistent with its use the module code, where "geoip_record_by_addr" is called. This bit me as I was grepping through the source for the definition of this function to understand how geoip handles data internally.
Comment | File | Size | Author |
---|---|---|---|
#4 | After_Patch-GeoIP.png | 4.5 KB | Aanal.addweb |
#4 | beforePatch-geoip.PNG | 4.47 KB | Aanal.addweb |
geoip_record_by_addr_capitalization.patch | 391 bytes | cotto | |
Comments
Comment #1
drewish CreditAttribution: drewish commentedI actually think we should avoid changing the upstream code and instead correct out calls to it.
Comment #2
drewish CreditAttribution: drewish commentedOh I see what you're saying, we're using the same name they use to call it... I'd probably be okay with this then.
Comment #3
drewish CreditAttribution: drewish commentedComment #4
Aanal.addweb CreditAttribution: Aanal.addweb at AddWeb Solution Pvt. Ltd. commented@drewish, Thanks for the patch it works well As I tested it by applying it manually in module file and it updates the required change. PFA
Comment #5
bojanz CreditAttribution: bojanz at Centarro commented