The form used to add grouptype subscriptions is missing widget titles.

og_notifications-add-form-labels.patch1.65 KBmstef
FAILED: [[SimpleTest]]: [MySQL] 257 pass(es), 9 fail(s), and 0 exception(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


ezra-g’s picture

Status: Active » Needs review

Marking as needs review.

Grayside’s picture

Status: Needs review » Needs work
+++ b/modules/og_notifications/
@@ -66,18 +66,21 @@ function og_notifications_add_form($form_state, $account, $groups) {
+    '#title' => t('Notify me of new content of these types'),

Very verbose. Can we have a shorter title and a description to round out the information?

greggles’s picture

Status: Needs work » Needs review
Issue tags: +Needs usability review

tbh, I'll take verbose and working over broken?

greggles’s picture

Status: Needs review » Needs work

didn't mean to flip-flop statuses.

Grayside’s picture

Status: Needs work » Fixed

Applied the patch and took a look. Actually, verbosity kind of fits, can't think of anything shorter.
Seems like that particular form element's options are possibly broken, and should be #multiple, but those are separate issues.

Status: Fixed » Closed (fixed)
Issue tags: -Needs usability review

Automatically closed -- issue fixed for 2 weeks with no activity.