Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In media_youtube.theme.inc there is a '; hanging on the end of line 43. Because of the way this block of text is it shouldn't be there and is coming through in the display. This needs to be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | video-embed-contains-semi-colon-365186-15.patch | 2.51 KB | katbailey |
| #12 | video-embed-contains-semi-colon-365186-12.patch | 2.16 KB | clemens.tolboom |
| #11 | YouTubeEmbed01.jpg | 23.97 KB | Osiris Indriya |
| #9 | video-embed-contains-semi-colon-365186-9.patch | 2.16 KB | clemens.tolboom |
| #4 | media_youtube_1043820.patch | 1003 bytes | pixelmord |
Comments
Comment #1
pixelmord CreditAttribution: pixelmord commentedI noticed that also, but only when Javascript is disabled.
See attached patch against alpha-4
Comment #2
mfer CreditAttribution: mfer commentedYou can't put a # in the file name. Isn't letting me get to it.
Comment #3
pixelmord CreditAttribution: pixelmord commentedSorry, I wasn't thinking....
I will attach a new patch as soon as I get back in the office, but until then, just remove the two mentioned characters in Line 43 by hand.
Comment #4
pixelmord CreditAttribution: pixelmord commentedso here is the patch with a url-safe name ...
Comment #5
aspilicious CreditAttribution: aspilicious commentedUsed this on my dev site, works :)
Comment #6
silkogelman CreditAttribution: silkogelman commentedconfirmed: #4 works on a fresh D7 install with these modules:
colorbox-7.x-1.0-beta2
styles-7.x-2.0-alpha5
multiform-7.x-1.0-beta1
media-7.x-1.0-beta3
media_gallery-7.x-1.0-beta3
media_youtube-7.x-1.0-alpha4
Comment #7
Thomas Bosviel CreditAttribution: Thomas Bosviel commented#4 works. Thanks.
Comment #8
effulgentsia CreditAttribution: effulgentsia commentedThanks! #4 looks good. I'll commit it when I get my GIT setup, or maybe another maintainer will beat me to it.
Comment #9
clemens.tolboomThe patch from #4 is not complete. The $variables['output'] is set twice too.
Comment #10
Osiris Indriya CreditAttribution: Osiris Indriya commentedAfter using patch in #9, I am still seeing the ' in a views panel pane. Only the ; has been removed.
Comment #11
Osiris Indriya CreditAttribution: Osiris Indriya commentedHere is a photo of the pane I am speaking of.
Comment #12
clemens.tolboomYou are correct.
Please try again.
Comment #13
aquariumtap CreditAttribution: aquariumtap commentedThe patch from #12 worked for me. Thanks!
Comment #14
clemens.tolboomTested by aquariumtap
Comment #15
katbailey CreditAttribution: katbailey commentedSorry for the noise, but I need a version of the patch that drush make can apply...
Comment #16
effulgentsia CreditAttribution: effulgentsia commentedHey, I'm starting to get the hang of git. Committed to 7.x-1.x. Please re-open this issue if I screwed up the commit. Thanks.