Module uninstall doesn't remove all used variables.

This should probably be done in 6.x, too.

Comments

troky’s picture

Variables used in 7.x:

  variable_del('advanced_forum_style');
  variable_del('advanced_forum_hide_created');
  variable_del('advanced_forum_topic_pager_max');
  variable_del('advanced_forum_get_new_comments');
  variable_del('advanced_forum_add_local_task');
  variable_del('advanced_forum_button_links');
  variable_del('advanced_forum_collapsible_containers');
  variable_del('advanced_forum_disable_breadcrumbs');
  variable_del('advanced_forum_forum_disabled');
  variable_del('advanced_forum_stats_posts');
  variable_del('advanced_forum_styled_node_types');
  variable_del('advanced_forum_style_all_comments');
  variable_del('advanced_forum_style_only_forum_tagged');
  variable_del('advanced_forum_style_teasers');
  variable_del('advanced_forum_time_ago_cutoff');
  variable_del('advanced_forum_topic_title_length');
  variable_del('advanced_forum_use_topic_navigation');
  variable_del('advanced_forum_views_as_tabs');
  variable_del('advanced_forum_forum_page_breadcrumb');
  variable_del('advanced_forum_user_picture_preset');
  variable_del('advanced_forum_use_taxonomy_image');
Michelle’s picture

It used to, a long time ago. But I found it caused nasty errors if it tried to remove a variable that didn't exist and there were major headaches when the variable name changed and different versions had different variables. So I ended up ripping all that out figuring leftover variables were better than crashing the site.

I'd be willing to add it back in if it's been fixed so it doesn't crash the site anymore. But I'd like to wait until closer to 2.0 as the list could potentially change before then.

Michelle

troky’s picture

Status: Active » Needs review

I don't know how can this crash the site since variable_del uses simple query to delete variable from database.

Anyway, I've put this in 7.x uninstall and I will monitor behavior since I do many (un)install cycles for testing purposes these days.

Michelle’s picture

It was a very long time ago, back in the early days of 1.x. It's all a bit fuzzy now but I remember it just totally choked if I tried to delete a variable to clean up that wasn't there because they had a newer version. I just ended ripping it all out.

Michelle

troky’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Priority: Normal » Minor
Status: Needs review » Postponed

This seems to work in 7.x.
I'll push this to 6.x and you decide what do you want with this.

Scyther’s picture

Would like to see this to! Maybe in 6.x-2.0-beta version? But definitely in the 6.x-2.0 release.

Michelle’s picture

Status: Postponed » Active

Yeah, will definitely be in 2.0. Really don't need a tag at this point. 2.0 is a very long way off. Doesn't need to be postponed, though.

Michelle