Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Module uninstall doesn't remove all used variables.
This should probably be done in 6.x, too.
Module uninstall doesn't remove all used variables.
This should probably be done in 6.x, too.
Comments
Comment #1
troky CreditAttribution: troky commentedVariables used in 7.x:
Comment #2
MichelleIt used to, a long time ago. But I found it caused nasty errors if it tried to remove a variable that didn't exist and there were major headaches when the variable name changed and different versions had different variables. So I ended up ripping all that out figuring leftover variables were better than crashing the site.
I'd be willing to add it back in if it's been fixed so it doesn't crash the site anymore. But I'd like to wait until closer to 2.0 as the list could potentially change before then.
Michelle
Comment #3
troky CreditAttribution: troky commentedI don't know how can this crash the site since variable_del uses simple query to delete variable from database.
Anyway, I've put this in 7.x uninstall and I will monitor behavior since I do many (un)install cycles for testing purposes these days.
Comment #4
MichelleIt was a very long time ago, back in the early days of 1.x. It's all a bit fuzzy now but I remember it just totally choked if I tried to delete a variable to clean up that wasn't there because they had a newer version. I just ended ripping it all out.
Michelle
Comment #5
troky CreditAttribution: troky commentedThis seems to work in 7.x.
I'll push this to 6.x and you decide what do you want with this.
Comment #6
Scyther CreditAttribution: Scyther commentedWould like to see this to! Maybe in 6.x-2.0-beta version? But definitely in the 6.x-2.0 release.
Comment #7
MichelleYeah, will definitely be in 2.0. Really don't need a tag at this point. 2.0 is a very long way off. Doesn't need to be postponed, though.
Michelle