Previewing a scheduled node will result in PHP warnings [#1036296]

Warning: date_timezone_set() expects parameter 1 to be DateTime, boolean given in format_date() (line 1905 of /var/www/drupal-7.x-dev/includes/common.inc).
Warning: date_format() expects parameter 1 to be DateTime, boolean given in format_date() (line 1915 of /var/www/drupal-7.x-dev/includes/common.inc).
Warning: date_timezone_set() expects parameter 1 to be DateTime, boolean given in format_date() (line 1905 of /var/www/drupal-7.x-dev/includes/common.inc).
Warning: date_format() expects parameter 1 to be DateTime, boolean given in format_date() (line 1915 of /var/www/drupal-7.x-dev/includes/common.inc).

Comments

Comment #1

Eric-Alexander Schaefer CreditAttribution: Eric-Alexander Schaefer commented 22 January 2011 at 23:21

I think I found it.

    if (isset($form_state['values']['op']) && $form_state['values']['op'] == t('Preview')) {
      $defaults = new StdClass;
      $defaults->publish_on = $form_state['values']['publish_on'];
      $defaults->unpublish_on = $form_state['values']['unpublish_on'];
    }

The default values are coming from the form state when previewing. The form state value are strings, not integer timestamps. format_date() only eats timestamps. Why did this work in D6?

I will look into this tomorrow. Which is actually today over here... *yawn*

Comment #2

Eric-Alexander Schaefer CreditAttribution: Eric-Alexander Schaefer commented 23 January 2011 at 08:09

One more:

Notice: A non well formed numeric value encountered in scheduler_node_view() (line 539 of /var/www/drupal-7.x-dev/sites/all/modules/scheduler/scheduler.module).

Comment #3

Eric-Alexander Schaefer CreditAttribution: Eric-Alexander Schaefer commented 23 January 2011 at 09:13

Status:

Active

» Fixed

scheduler_preprocess_node() was the culprit. The there did not check if the scheduling values were numeric...

http://drupal.org/cvs?commit=487306

Comment #4

6 February 2011 at 09:20

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #5

Hitby

he/him

CreditAttribution: Hitby commented 8 May 2012 at 11:20

Status:

Closed (fixed)

» Active

Using the latest dev version - when previewing a node I get

Notice: A non well formed numeric value encountered in scheduler_node_view() (line 587 of /path/to/site/sites/all/modules/scheduler/scheduler.module).

Appreciate any help!

Comment #6

jonathan1055 CreditAttribution: jonathan1055 commented 8 December 2012 at 12:03

Yes I had this too. It does need looking at. The link in #3 no longer shows the actual commit, but I found it here:

http://drupalcode.org/project/scheduler.git/commit/ed9baf6

Jonathan

Comment #7

jonathan1055 CreditAttribution: jonathan1055 commented 8 December 2012 at 14:54

Priority:

Critical

» Normal

The problem raised in #5 was caused by scheduler_node_view(). Given that I already have a patch for that function in #1781186: Metatag googlebot:unavailable_after is written when node is shown in a view, panel or block I have modified the code to solve both problems, and created a new patch.

Jonathan