More than one wrapper class

No need for multiple issues. I see you're already on the other issue: http://drupal.org/node/939992

In my opinion, that other issue isn't quite the same thing. This issue is about allowing multiple classes, while the other is about errors thrown when certain characters are included in the class name.

I'll look into creating a patch for this.

Jej: Well, patching a drupal core function is not an option for us, so your definition of 'quite easy' does not match mine. Then again, you want to refer to us as 'Drupal policemen' so I guess we're the enemy rather than people trying to help.

dboulet: Okay, yes, I agree that we shouldn't be converting spaces to dashes.

Here's what makes sense to me, please review.

I'm not sure we need to explode here. I think I'd rather just go with our own replacement for drupal_clean_string_identifier -- we used to have views_css_safe(). Maybe we need to resurrect that.

I'm also trying to use two classes in an element class. Can't find a work around. I found this issue which matches the use case. I've noticed that the wrapper classes make use in last dev-1 of the explode and therefore I can put several classes there but no "Replacement patterns" ar available for the wrapper.

I tried the patch though which is now a bit different because of the recent modifications in views_handler_field.inc
It works for me.

Attached updated patches for theme/theme.inc and handlers/views_handler_field.inc.

I think I'll settle for a bigger css code with just one class for the moment, for my production site I have to release, instead of relying on a patch when I don't know the outcome of this issue.

Can you please create a single patch for this issue? This would be cool

Additional some kind of usage of drupal code style would be helpful, too. So for example use two spaces instead of a tab.

Here we are dereine, I just updated the patch in #6 to matc the code lines. I tested this patch, and it works, I can now add more classes to one element in a view.

The patch will work, but merlinofchaos suggested in #7 that we not use this method. Unless he changes his mind, we need to come up with a new patch that replaces explode() and drupal_clean_string_identifier() with our own sanitizing function.

I don't think that it'll work Jej, I'm pretty sure that drupal_clean_css_identifier() filters out "invalid" characters (including spaces) after the replacements have been made.

@dboulet

I'm pretty sure that drupal_clean_css_identifier() filters out "invalid" characters (including spaces) after the replacements have been made.

No it doesn't, and a whitespace is by no means an invalid character in that context. drupal_clean_css_identifier is overly aggressive anyway, that's why I filed bug: #1109854: Overly aggressive transliteration in drupal_clean_css_identifier removes underscores from classes.

$ drush php-eval 'print drupal_clean_css_identifier("one two") . "\n";'
one-two
$ drush php-eval 'print drupal_clean_css_identifier("one two", array("_" => "-", "/" => "-", "[" => "-", "]" => "")) . "\n";'
onetwo

Spaces are always stripped out.

There's a new patch but status was never set to needs review!

Committed and pushed #10. Thanks!

@dboutlet you're right, the common space character U+0020 does indeed get stripped out by drupal_clean_css_identifier, as anything below U+00A1. This shows how broken drupal_clean_css_identifier, try the same with any other space character like U+2002, EN SPACE, U+2003, EM SPACE or any other whitespace character above U+00A1:

$ drush php-eval 'print drupal_clean_css_identifier("one\xe2\x80\x82two") . "\n";'
one two
$ drush php-eval 'print drupal_clean_css_identifier("one\xe2\x80\x83two") . "\n";'
one two

Instead of using escape sequences, you can try these examples by directly typing the respective Unicode characters, it'll still work.

Sorry @merlinofchaos, didn't mean to change the status, you changed the status while I was still writing a reply.

I assume crosspost changed status.

In #939992: "CSS classes must be alphanumeric or dashes only." I think underscores should be included which is targeted at 6.x-3.x, I was referred to this ticket, when I argued that underscores U+005F in CSS classes should be allowed and possible too. Now #10 solved the problem of allowing more than one CSS class but still involves drupal_clean_css_identifier, which replaces underscores by dashes. What should I do, file a new ticket for 7.x-3.x?

Filed a new feature request with a patch based on #10: #1111258: Allow underscores in CSS classes, thanks.

I think this was somehow applied wrongly. Comparing the patch in #10 and the current code in Git, somehow the explode() call is missing. This means a string is handed to array_map() and implode(), resulting in tons of error notices.

Yup, comparing the commit to the patch above, you see that they do not match.

This should fix it I think.

EDIT: I've marked #1051034: Allow field wrapper class to take multiple classes as a duplicate of this of this issue. I've included a change in this patch to modify the code committed in that issue to be more consistent with our patch here.

Whoops. My push to fix the missing explode got missed so that was sitting in my local repo overnight. One of the loops not getting changed to array_walk I had missed, tho, so pushed those as separate commits.