Realname very slow with "Realname: Name" and "Link to this users profile" in views lists [#1019428]

Hi,

Realname is slow in the following case:

- Add a Realname: Name field to the view and set it to "Link to this users profile" (500 ms)

Without this Link the performance is: 80ms.

The reason is that the "realname" field of the account object is not populated in the views handler and such the database has to be queried again for each user displayed.

With 100 records it gets worth and reaches 2 sec of display calculation.

Easy fix:

--- realname/realname_handler_field_user_name.inc
+++ realname/realname_handler_field_user_name.inc
@@ -27,6 +27,7 @@ class realname_handler_field_user_name extends views_handler_field_user_name {
}
elseif (!empty($this->options['link_to_user'])) {
$account->name = $values->{$this->field_alias};
+ $account->realname = $values->{$this->aliases['realname']};
return theme('username', $account);
}
}

Please apply.

Best Wishes,

Fabian (LionsAd)

Comment	File	Size	Author
#2	realname_very_slow_with-1019428-2.patch	2.15 KB	joelpittet
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Fabianx CreditAttribution: Fabianx commented 8 January 2011 at 07:33

Here is the code again:

diff --git a/sites/all/modules/realname/realname_handler_field_user_name.inc b/sites/all/modules/login/realname/realname_handler_field_user_name.inc
index c61b0e3..56bb210 100644
--- a/sites/all/modules/realname/realname_handler_field_user_name.inc
+++ b/sites/all/modules/realname/realname_handler_field_user_name.inc
@@ -27,6 +27,7 @@ class realname_handler_field_user_name extends views_handler_field_user_name {
       }
       elseif (!empty($this->options['link_to_user'])) {
         $account->name = $values->{$this->field_alias};
+        $account->realname = $values->{$this->aliases['realname']};
         return theme('username', $account);
       }
     }