Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I have to create a filter for an solr organic group argument so the og facet works with views.
CCK is currently supported in apachesolr_views; would this module also be a good spot to house an og arguments/filter? or should that be in a separate module?
If this module is an ok spot for it, i'll try and submit a patch.
Comment | File | Size | Author |
---|---|---|---|
#11 | apachesolrviews-ogsupport_1014988_11.patch | 45.68 KB | dominikb1888 |
#10 | apachesolrviews-ogsupport_1014988_10.patch | 45.68 KB | dominikb1888 |
#9 | apachesolrviews_og.patch | 5.08 KB | dawehner |
#8 | apachesolrviews_og.patch | 4.38 KB | dawehner |
#3 | apachesolr_views_args_0.patch | 772 bytes | robbertnl |
Comments
Comment #1
hatsch CreditAttribution: hatsch commenteddid you come any further with that?
+1 for an og argument and filter
Comment #2
Ravi.J CreditAttribution: Ravi.J commentedThe idea of providing OG integration is great, however i am not sure if that is something that needs to be part of ApacheSolr Views module, I have started a discussion on a new project proposal ApacheSolr Views Assorted Plugins
Comment #3
robbertnl CreditAttribution: robbertnl commentedDespite of the discussion if this should be part of the module or not, I made a patch for this. The patch provides only group id arguments.
This patch also includes the bugfix as mentioned here: http://drupal.org/node/449190.
This is the wrong patch, please use patch from #5
Comment #4
robbertnl CreditAttribution: robbertnl commentedComment #5
robbertnl CreditAttribution: robbertnl commentedAnd now the corresponding patch :)
Comment #6
dawehnerIn general this works fine for me. Thanks!!
This looks like a good change, see below, but a bit out of scope this patch.
Here is some space added
some space as well, sorry
this is now not needed anymore with git
In general this looks fine, if there is a rerole of the few things.
Comment #7
dawehnerAdditional i think, that this should perhaps better belong into apachesolr_og
Comment #8
dawehnerUpdated the patch to fix some style problems and set the group context on the argument handler like the original handler.
Comment #9
dawehnerThe facets might shouldn't have () as part of the link.
Comment #10
dominikb1888 CreditAttribution: dominikb1888 commentedI recreated the patch form #9 against the latest dev. It also adds a few changes to adhere to coding standards.
Comment #11
dominikb1888 CreditAttribution: dominikb1888 commentedThis corrects a wrong handler reference in my previous patch