Some incorrect conditions in amazon_item_clean_xml() [#1014128]

(I could easily be mistaken)

In amazon.module,

line 537: if (empty($item['isbn'])) {
should be: if (!empty($xml->ItemAttributes->ISBN])) {

and

line 540: if (empty($item['ean'])) {
should be: if (!empty($xml->ItemAttributes->EAN])) {

Otherwise the conditions will always evaluate to true.

Comment	File	Size	Author
#1	amazon.broken_conditions_1014128_01.patch	652 bytes	rfay
#1

Comments

English

Palisade, CO, USA

CreditAttribution: rfay commented 29 January 2011 at 22:18

Status:

Active

» Needs review

File	Size
amazon.broken_conditions_1014128_01.patch	652 bytes

Yep, thanks for the report. No-brainer... but it means this code has never been used.

English

Palisade, CO, USA

CreditAttribution: rfay commented 29 January 2011 at 22:28

Status:

Needs review

» Fixed

Committed:

12 February 2011 at 22:30

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.