Home » Administer » Site configuration » File system

Under "Download method," a still more definite recommendation would be welcome. The default is set to "public." Is this the setting most recommended or most likely to be used? If not, it should be changed.

This section can be especially daunting for new users because they're told that if they make the wrong choice they can't change it later without risking problems. So extra clarity is called for.

CommentFileSizeAuthor
#12 filesystemtext_2.patch3.04 KBkeith.smith
#4 filesystemtext.patch3.14 KBkeith.smith
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Paul Natsuo Kishimoto’s picture

Paul Natsuo Kishimoto CreditAttribution: Paul Natsuo Kishimoto commented
Version: 5.0-beta2 » 5.x-dev

Updated to 5.x-dev.

Paul Natsuo Kishimoto’s picture

Paul Natsuo Kishimoto CreditAttribution: Paul Natsuo Kishimoto commented
Version: 5.x-dev » 6.x-dev
keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented
Component: base system » documentation

Moving to documentation component.

keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented
Title: Core: Interface text for "file system" -- more clarity needed » Interface text for "file system" -- more clarity needed
Status: Active » Needs review
FileSize
filesystemtext.patch3.14 KB

Patch attached that, while arguably not adding much additional clarity, does make a few simple text changes.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

These are sensible changes. public/private file handling may get into D7 so there's going to be less or no need to state a preference a release from now.

RTBC.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Needs review

Why is

Relative paths will be resolved from the Drupal installation directory.

better then

Relative paths will be resolved relative to the Drupal installation directory.

? The current one seems to be cleaner to me than the new one proposed.

keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented

I'm not sure that one is any "better" than the other; the original one:

Relative paths will be resolved relative to the Drupal installation directory.

seemed somewhat redundant. If its a relative path, then surely it will be resolved relatively.

But, that said, the change may not be much better.

At one iteration, I had something like:

Relative paths (paths that do not begin with '/') will be resolved from the Drupal installation directory.

That had the advantage of halfway explaining whether they had a relative path or not, but did not account for cross-platform peculiarities in file path naming. I suppose this might not be a problem -- I've never actually looked on a Windows system to see what this path looks like; perhaps the functions in question take care of that automatically?

Dries’s picture

Dries CreditAttribution: Dries commented

t('Location where uploaded files will be kept during previews. Relative paths will be resolved from the Drupal installation directory.'), '#after_build' => array('system_check_directory'),

I'm not sure what value the last sentence (i.e. 'Relative paths ...') adds -- why is this important for the administrator? That sentence looks redundant to me?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

The first change in the patch introduces a small error. “If the download method is to private” should be “. . . set to private.”

For the second change, does this work better: “Location where uploaded files will be kept during previews. You can enter either an absolute path (a path that starts from the root of your server) or a relative path (a path that starts from your Drupal installation directory). Relative paths do not begin with ‘/’.” (Is this the intended meaning?)

The third change seems to suffer from “you-phobia.” “You can change this at any time” is more clear, simple, and direct than “While this may be changed at any time.”

By the way, we still haven’t answered for the perplexed novice user my original question: Which download method is the recommended default?

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented

I'd say absolute novices are unlikely to want fine grained file access permissions, and are quite likely to have server resource restrictions which they'll come against quicker with private file downloads. For a recommendation sentence:

"Unless your site has a need for fine grained control over file downloads, you should choose the public download method."

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

"Unless your site has a need for fine grained control over file downloads, you should choose the public download method."

Great!

(Just one small change: "fine-grained," hyphenated.)

keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented
FileSize
filesystemtext_2.patch3.04 KB

Patch attached with adds the missing word from #9, addresses Dries' comment in #8. I used a variation of the changes suggested in #10 and #11.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Looks good to me!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Excellent. I've committed the improvements to CVS HEAD so that they'll be part of Drupal 6. Keep it coming. :)

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.