Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
- fix the status report width error under IE8
- fix border bug (IE6~7)
IE6~7 do not support TR border.
Comment | File | Size | Author |
---|---|---|---|
#12 | system_report.patch | 1.53 KB | droplet |
#11 | system_report.patch | 1.78 KB | droplet |
#11 | after_patch_ie8.jpg | 119.99 KB | droplet |
#11 | after_patch_firefox.jpg | 138.1 KB | droplet |
#11 | IE_no_patch.jpg | 57.05 KB | droplet |
Comments
Comment #1
droplet CreditAttribution: droplet commentedComment #3
droplet CreditAttribution: droplet commentedComment #4
aspilicious CreditAttribution: aspilicious commentedCould you provide before after screenshots?
Comment #5
droplet CreditAttribution: droplet commentedattached a before screenshot. after is same as what you see in FF
Comment #6
mtiftsubscribe
Comment #7
droplet CreditAttribution: droplet commentedlets add IE tag
Comment #8
bfroehle CreditAttribution: bfroehle commentedComment #9
Jeff Burnz CreditAttribution: Jeff Burnz commentedPlease explain what this patch does, why we need it and why we should accept an hack for IE8. Also isnt this just a duplicate of #987982: Remove left and right borders for tr.merge-down td and tr.merge-down th surely efforts can be combined in one?
Comment #10
droplet CreditAttribution: droplet commentedhmm.. hard to explain it... browsers with diff behavior for table without FIXED WIDTH of columns.
as @benjifisher mention in #987982, it's different issues. #987982 more target to Bartik only.
actually, it's patch with a few clean up too.
(it's only fix the bug and doesn't change any designs)
Comment #11
droplet CreditAttribution: droplet commentedNo one interest of IE problem, LOL. But it's more than IE now.
This style make browsers used different way to calc table columns width (fixed the problem under IE, see attached images. And it also better in other browsers,e.g.render performance. no harms)
against Stark theme, no needs these style
Only Seven theme needed.
IE < 9 do not supports styles on TR
It could safely backport as well :)
Comment #12
droplet CreditAttribution: droplet commentedIt's right one.
Comment #13
sunContributed modules are using the .merge-down/-up feature, too, so limiting the styles to the status report would be a regression.
Comment #14
droplet CreditAttribution: droplet commentedComment #15
Sumit kumar CreditAttribution: Sumit kumar commentedComment #16
LewisNyman CreditAttribution: LewisNyman commentedWe no longer support IE 6/7/8 so we don't need to fix this in D8. Feel free to reopen to fix this in D7.
Comment #17
droplet CreditAttribution: droplet commentedThis is a clean up, more than IE supports.
However no one really care about it after few years, closing is make sense to me :) ( Feeling sad actually )