Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Hi
If I have set max resolution for NG imagefield, and I am uploading image with bigger resolution, I got a message "Image was resized to fit max allowed resolution xxx*xxx pixels"
But while I am uploading e.g. 50-100-200 images, I got 50-100-200 these messages, it is annoying, it takes a lot of space on the page - 200 lines with the same messages, and it is a bit weird.
Do you think that you could change it to only one message "x images was resizes to fit maximum allowed resolution xxx*xxx pixels." ?
Imho it will be good for usability and less weird for simple users.
maybe this is more imagefgield stuff as nodegallery, but maybe with some hook it could be done.
thanks
Igor
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | ng_messages_resize.jpg | 144.01 KB | igorik |
Comments
Comment #1
igorik CreditAttribution: igorik commentedhere is screenshot
Comment #2
scroogie CreditAttribution: scroogie commentedPerhaps we could call a drupal_get_messages($type = 'info') or whatever the message type is, to clear the queue of these messages for plupload. Let's wait for #996978: NG3 workflow improvements, as we will introduce a javascript function there for when the queue is finished. We can plug the message queue manipulation into that later.
Comment #3
scroogie CreditAttribution: scroogie commentedMhm, I guess this actually belongs in the plupload queue. I'm not sure it will be accepted though. Could just as well be a won't fix.
Comment #4
gregglesThe drupal_set_message function has a parameter for whether or not to "repeat" a message. I think if that is set to FALSE it will solve this.
Feel free to re-assign to some new issue queue if that feels appropriate, but as far as plupload is concerned this is a fixed support request. There's nothing else plupload could really do.
Comment #5
scroogie CreditAttribution: scroogie commentedJust for clarification, does that mean you're using this $repeat parameter in the latest version?
Comment #6
gregglesNo, it means there's nothing for plupload to do. The module that creates that message (which is not plupload) would have to use the $repeat parameter.
Comment #7
justintime CreditAttribution: justintime commentedJust to clarify a bit, I'm pretty sure it's imagefield emitting this message. It's certainly not node gallery nor plupload. Since imagefield is unaware that it's being used in a 'bulk' use case, it simply emits one message per occurrence. On the next page load after a bulk upload, it renders all messages in the queue, resulting in the screenshot above.
IMO, this is one of those issues where the fix could be worse than issue itself. If plupload started munging the messages that imagefield is trying to send, we begin skating on thin ice.
FWIW, core does this (printing a huge number of messages) too when you delete a huge number of nodes via batch API or views_bulk_operations.
So, in summary, this would technically likely be an issue for the imagefield queue, but I'm not going to be the one to move it over there. I feel that the devs have more productive things to focus on.