internationalization code review

Hi,

CivicActions is reviewing and upgrading multiple modules for use on client sites. Part of this work is an internationalization review of all strings output to the browser. A few problems were found with the imagecache HEAD version, but they all fall into 2 categories.

First of all, in Drupal 6 the parameters to the watchdog() function changed and you should now no longer run the watchdog log message through the t() function. It was changed so that the messages would appear in the language of the user viewing the logs, rather than the language of the user who triggered the log message. More details can be found at http://drupal.org/node/114774#watchdog_parameters

The other changes are all related to leading or trailing spaces in the strings provided to the t() function. These extra spaces cause problems for translators and often the translations don't appear because a space is missing in the .po file. It's therefore a good idea to ensure you don't have any leading or trailing spaces and if you do need to have a space (for concatenation reasons, etc), it's best if you put these spaces outside the call to t().

The only other thing I'd like to point out, though you're probably already aware of it, is that in Drupal 6 the po/ directory has been renamed to translations/. See http://drupal.org/node/114774#translations_directory

Cheers,
Stella