Environment is alpha14 with single server_master with ssl enabled. Disabling a site via the hostmaster interface doesn't take the site down or hide it from users. See log below:

Task starts processing
Running: /var/aegir/drush/drush.php @drupal-2010-10-20.example.com provision-disable --backend
Drush bootstrap phase : _drush_bootstrap_drush()
Load alias @drupal-2010-10-20.example.com
Loading drushrc "/var/aegir/platforms/drupal-6.19/sites/drupal-2010-10-20.example.com/drushrc.php" into "site" scope.
Drush bootstrap phase : _drush_bootstrap_drupal_root()
Loading drushrc "/var/aegir/platforms/drupal-6.19/drushrc.php" into "drupal" scope.
Initialized Drupal 6.19 root directory at /var/aegir/platforms/drupal-6.19
Found command: provision-disable (commandfile=provision)
Initializing drush commandfile: drush_make
Initializing drush commandfile: drush_make_d_o
Initializing drush commandfile: provision
Load alias @platform_Drupal619
Load alias @server_master
Loading mysql driver for the db service
Loading apache_ssl driver for the http service
Including /var/aegir/.drush/provision/http/disable.provision.inc
Including /var/aegir/.drush/provision/platform/disable.provision.inc
Including /var/aegir/.drush/provision/db/backup.provision.inc
Including /var/aegir/.drush/provision/platform/backup.provision.inc
Drush bootstrap phase : _drush_bootstrap_drupal_site()
Initialized Drupal site drupal-2010-10-20.example.com at sites/drupal-2010-10-20.example.com
Loading drushrc "/var/aegir/platforms/drupal-6.19/sites/drupal-2010-10-20.example.com/drushrc.php" into "site" scope.
Drush bootstrap phase : _drush_bootstrap_drupal_configuration()
Adding sites directory to /var/aegir/backups/drupal-2010-10-20.example.com-20101030.231903.tar.gz
Deleted mysql dump from sites directory
<strong>Template loaded: /var/aegir/.drush/provision/http/apache_ssl/vhost_ssl_disabled.tpl.php</strong>
Deleted SSL Certificate association stub for drupal-2010-10-20.example.com on example
apache on example has been restarted
Template loaded: /var/aegir/.drush/provision/provision_drushrc_alias.tpl.php
Changed permissions of /var/aegir/.drush/drupal-2010-10-20.example.com.alias.drushrc.php to 600
Generated config Drush configuration file
Changed permissions of /var/aegir/.drush/drupal-2010-10-20.example.com.alias.drushrc.php to 400
Template loaded: /var/aegir/.drush/provision/provision_drushrc_site.tpl.php
Changed permissions of /var/aegir/platforms/drupal-6.19/sites/drupal-2010-10-20.example.com/drushrc.php to 600
Generated config Site Drush configuration file
Changed permissions of /var/aegir/platforms/drupal-6.19/sites/drupal-2010-10-20.example.com/drushrc.php to 400
Command dispatch complete
Peak memory usage was 11.21 MB
Command dispatch complete
Peak memory usage was 24.68 MB

Virtual hosts file has no redirect directives:

<VirtualHost *:80>

  DocumentRoot /var/aegir/platforms/drupal-6.19

  ServerName example.com
  SetEnv db_type  mysqli
  SetEnv db_name  example
  SetEnv db_user  example
  SetEnv db_passwd  JafQzR7zMK
  SetEnv db_host  example
  SetEnv db_port  3306



# Extra configuration from modules:

    # Error handler for Drupal > 4.6.7
    <Directory "/var/aegir/platforms/drupal-6.19/sites/example.com/files">
      SetHandler This_is_a_Drupal_security_line_do_not_remove
    </Directory>

</VirtualHost>

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

After hearing about this on IRC, and reading that task log, it seems that a server invoking the apache_ssl service, expects to find the 'disabled vhost' template in the apache_ssl directory, which is not there. (do we need to duplicate this)?

I don't know if the issue is compounded by the fact that this is a HTTP port 80 vhost on an apache_ssl service.

adrian’s picture

adrian CreditAttribution: adrian commented

this is partially fixed for apache, but nginx still needs updating.

[master 0a172d3] Add disabled template for apache_ssl , was missing before. #958094
2 files changed, 37 insertions(+), 2 deletions(-)

adrian’s picture

adrian CreditAttribution: adrian commented
Priority: Normal » Critical
Status: Active » Needs review
Issue tags: +aegir-nginx

I added a _ssl_disabled template for nginx, but i dont have the ability to test it.

omega8cc: you _have_ to test this before release. basically just use the nginx_ssl variant (with or without an ssl enabled site) and try to disable it, if it redirects you are golden.

[master 2a8ec66] Add UNTESTED nginx_ssl_disabled.tpl.php. This needs to be verified as working before release. #958094
1 files changed, 34 insertions(+), 0 deletions(-)
create mode 100644 http/nginx_ssl/vhost_ssl_disabled.tpl.php

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented
Status: Needs review » Reviewed & tested by the community

Marking as RTBC. Works fine with Nginx, thanks.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Reviewed & tested by the community » Fixed

Thanks for testing!

Status: Fixed » Closed (fixed)
Issue tags: -aegir-nginx

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +aegir-nginx

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.

  • Commit 2b26e37 on debian, dev-koumbit, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by adrian: 
    partial fix to the lack of disable - #958094
  • Commit ab2f7ce on debian, dev-koumbit, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by adrian:
    Add disabled template for apache_ssl , was missing before. #958094
  • Commit 660afdb on debian, dev-koumbit, dev-migrate_aliases, dev-multiserver-install, prod-koumbit, dev-ssl-ip-allocation-refactor, dev-1205458-move_sites_out_of_platforms, 7.x-3.x, dev-subdir-multiserver, 6.x-2.x-backports, dev-helmo-3.x by adrian:
    Add UNTESTED nginx_ssl_disabled.tpl.php. This needs to be verified as...