Patch to make teasers work in a logical method for unlimited length. [#9497]

Basically this allows the  to work even when the teaser length to is set to unlimited. I find this a much more logical solution esp. and intranet sites where they are more manuals and documentation.

Comment	File	Size	Author
#6	node_size_zero_2.patch	1003 bytes	gordon
#6
#3	node_size_zero_1.patch	1.04 KB	gordon
#3
#1	node_size_zero_0.patch	987 bytes	gordon
#1
	node_size_zero.patch	1.99 KB	gordon

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

gordon CreditAttribution: gordon commented 25 July 2004 at 07:16

File	Size
node_size_zero_0.patch	987 bytes

original submited patch had my node_submit() changes included it it.

Comment #2

Dries CreditAttribution: Dries commented 25 July 2004 at 17:54

The code comments need to be updated as well ...

Comment #3

gordon CreditAttribution: gordon commented 3 August 2004 at 23:31

File	Size
node_size_zero_1.patch	1.04 KB

updated the patch, to include more comments, and also made the code fit the patch in the case where there is a size limit and it has a  the is more than a factor of 2 away from the start.

Comment #4

Steven CreditAttribution: Steven commented 4 August 2004 at 00:09

I'm not sure if the "outside of a factor of 2" bit is a good idea. Shouldn't 'break' override the size settings? At least this should be a togglable option IMO. You should also keep in mine that strpos uses bytes, not characters, so you don't have much guarantees anyhow as far as length goes.

Comment #5

TDobes CreditAttribution: TDobes commented 4 August 2004 at 03:01

I agree with Steven that the whole "factor of two" business will be confusing to users. This comment seems to exist in the unpatched node.module merely as a relic from the past. The code that actually enforced this condition was removed about a year ago (note that the help text presented to users was updated, but the comment was not). Unless there's a really good reason for it, I suggest we just remove the comment.

As for the rest of the patch, the ability to selectively use teasers would be useful for admins that dislike teaser auto-generation. Simply disabling the break tag (as we do now) could be confusing. +1 as long as the "factor of two" code is removed.