Doesn't cache if URL variables contain [ or ]. FIX INCLUDED. [#942586]

paths like
events?title=foo&field_event_category_value=All&date_filter%5Bvalue%5D%5Byear%5D=&date_filter%5Bv (...)
that are displayed in the browser as events?title=dfsdf&field_event_category_value=All&date_filter[value][year]=&date_filter (...)
are not loaded out of the cache, after correctly caching it.

In the source of the current version, two lines which are commented out, must be enabled again to make it work.
That are the lines no. 2150 and 2151

    //$end = str_replace('[', '%5B', $end);
    //$end = str_replace(']', '%5D', $end);

replace to

    $end = str_replace('[', '%5B', $end);
    $end = str_replace(']', '%5D', $end);

Comments

Comment #1

mikeytown2 CreditAttribution: mikeytown2 commented 15 October 2010 at 17:07

Will it serve those cached files on your box?

Comment #2

jaykaycgn CreditAttribution: jaykaycgn commented 19 October 2010 at 23:11

With the lines uncommented: yes.
With the lines commented: No. It saves the files in chache/... as ascii-characters "as expected" (with ['s an ]'s) but the module probably looks for files with the encoded characters ("%5B" ...).

Comment #3

mikeytown2 CreditAttribution: mikeytown2 commented 19 October 2010 at 23:22

Status:

Active

» Needs review

Just to be super clear, because I took these out because apache would not serve these cached files thus I got rid of it. Apache (not anything in drupal) will serve the cached html with this file pattern, on your server; correct? Just so I know, what version of apache are you using?

Comment #4

jaykaycgn CreditAttribution: jaykaycgn commented 22 October 2010 at 10:15

Yes,

Apache (not anything in drupal) will serve the cached html with this file pattern, on your server; correct?

with the Pattern, Apache serves the "correct" files with my patch, *because* theyre saved in the filesystem with encoded [ and ] like field_event_category_value=All&date_filter%5Bvalue%5D%5Byear%5D=&date_filter%5Bv.

if left in original drupal doesn't give apache a chance to deliver the files, because the files that are stored in the filesystem with [ and ]'s are these are not found via drupal.