Help links are being displayed to users without regard for the advanced help permissions.

The theme function checks for "view advanced help popup" permission. If the user doesn't have that it displays a text link instead of the popup icon. I believe it should check for "view advanced help topic" permission before displaying the text link.

Patch to follow.

CommentFileSizeAuthor
#1 advanced_help-941866.patch628 byteschaps2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chaps2’s picture

FileSize
628 bytes
chaps2’s picture

Status: Active » Needs review
gisle’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Assigned: Unassigned » gisle
Issue summary: View changes
Status: Needs review » Patch (to be ported)

Fixed in latest dev snapshot for 6.x-1.x. Need to be fixed in 7.x-1.x as well.

  • gisle committed d552700 on 6.x-1.x authored by chaps2
    Issue #941866 by chaps2: Fixed help links displayed to users without...
gisle’s picture

Status: Patch (to be ported) » Reviewed & tested by the community

  • gisle committed c0aa81a on 7.x-1.x authored by chaps2
    Issue #941866 by chaps2: Fixed help links displayed to users without...

  • gisle committed e2dec8d on 7.x-1.x authored by fgm
    Issue #941866 by fgm: Added support for themes
    

  • gisle committed c0aa81a on 8.x-1.x authored by chaps2
    Issue #941866 by chaps2: Fixed help links displayed to users without...
  • gisle committed e2dec8d on 8.x-1.x authored by fgm
    Issue #941866 by fgm: Added support for themes
    
  • gisle committed 23e7697 on 8.x-1.x
    Issue #941866 by gisle: Initial commit 8.x-1.x
    
gisle’s picture

Status: Reviewed & tested by the community » Fixed
gisle’s picture

Version: 7.x-1.x-dev » 7.x-1.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.