Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
system_ip_blocking() defines the variable $output
, but it doesn't use it.
Comment | File | Size | Author |
---|---|---|---|
#12 | 939918-9.patch | 697 bytes | joetsuihk |
#8 | 939918-8.patch | 533 bytes | amateescu |
#6 | 939918-2.patch | 716 bytes | joetsuihk |
#2 | 939918.patch | 737 bytes | joetsuihk |
Comments
Comment #1
bleen CreditAttribution: bleen commentedsomeone can learn how to create a patch with this
Comment #2
joetsuihk CreditAttribution: joetsuihk commentednice tag.
please try my patch.
Comment #4
bleen CreditAttribution: bleen commentedjoetsuihk - it looks like your patch is failing because patches always need to be relative to the root of you drupal install
Comment #5
apadernoThat means the filename should be modules/system/system.admin.inc; the patch should be then created using the arguments -u -p.
Comment #6
joetsuihk CreditAttribution: joetsuihk commentedobviously netbeans CVS is not good enough to cater different path for patches.
manually edited the patch
Comment #8
amateescu CreditAttribution: amateescu commentedHere's one that should work :)
Comment #9
joetsuihk CreditAttribution: joetsuihk commentedit is sad that netbeans CVS client do not work at all...
but @amateescu use git?
we can start using http://git.drupalcode.org/project/drupal.git to create patches?
Comment #10
amateescu CreditAttribution: amateescu commentedYes, i used git following this guide: http://drupal.org/node/707484
Comment #11
droplet CreditAttribution: droplet commented@joetsuihk
check it out: http://drupal.org/node/551858
Comment #12
joetsuihk CreditAttribution: joetsuihk commented@amateescu thx, will try later
try on my linux with cvs following:
http://drupal.org/node/320
http://drupal.org/patch/create
just want to try if my patch works on tests
Comment #13
droplet CreditAttribution: droplet commentedComment #14
webchickNice catch!
Committed to HEAD. Welcome to the core team, joetsuihk! :)