If theme_links is passed an empty array of links, it generates a UL block containing no LI elements. This is unnecessary HTML text and, it turns out, also a standard violation. Patch attached.

CommentFileSizeAuthor
theme-patch.txt601 bytesbjaspan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tmckeown’s picture

tmckeown CreditAttribution: tmckeown commented
Version: x.y.z » 4.7.4

Looks alright to me. I can see where passing on empty array would be a problem and this type of validation is propably necessary.

Trevor

chx’s picture

chx CreditAttribution: chx commented
Version: 4.7.4 » 5.x-dev
Status: Needs review » Reviewed & tested by the community
Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks!

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)