There should be a note near the top of UPGRADE.txt about upgrading between major releases and the need to be running the latest version of your current major release before upgrading to the next major release.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Beanjammin’s picture

Status: Active » Needs review
FileSize
704 bytes

Suggested changes.

axyjo’s picture

+1, but I'll wait for someone else to RTBC.

EvanDonovan’s picture

Status: Needs review » Needs work

"ie" should be "i.e." - I'll roll a new patch in a minute.

EvanDonovan’s picture

Status: Needs work » Needs review
FileSize
1.83 KB

Corrected spelling of "i.e." - also made a few other minor proofreading edits.

I'm not totally happy about this being the last bullet in the top list, since it takes away from the finality of "You have read through this entire document," but I don't see a better place for the warning, and it is absolutely essential that it be added to the document in a prominent place.

Hopefully someone can RTBC soon.

EvanDonovan’s picture

Here's an alternative version with the new sentence not part of the bulleted list. I actually prefer this one, but I'll let the community decide.

Either way, I think the wording is good (I didn't change that from Beanjammin's original patch).

fgm’s picture

I understand why you added the final dot, but it is likely to be confusing and limit copy/paste ability for users reading this in a downloaded text file. I think it would be better to leave it off.

EvanDonovan’s picture

@fgm: This patch fixes that. Also fixes the white space issue pointed out by marvil07.

I suffixed with D6 to prevent "wasting" a test bot. Let me know if I should've sent it to test bot. (I did test locally that it applied, and obviously it has no effect on code.)

I also attached the full updated file if that will help anyone review.

David_Rothstein’s picture

Status: Needs review » Reviewed & tested by the community

Looks like a no-brainer to me.

I think the testbot probably could have survived your one-patch onslaught :) But yes, there is obviously no way this could break tests. (Unless there's a mistake in the instructions and the testbot is smart enough to read English and therefore is led astray by what it reads...)

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks! :)

Status: Fixed » Closed (fixed)
Issue tags: -UPGRADE.txt

Automatically closed -- issue fixed for 2 weeks with no activity.