Classes marked 'final' are not picked up by the registry [#914312]

When scanning files for classes to be available for autoloading, _registry_parse_file() will ignore perfectly valid classes defined as final. So for example, the registry will pick up

class NodeController extends DrupalDefaultEntityController {

but if it were ever changed to

final class NodeController extends DrupalDefaultEntityController {

then the registry would ignore it. As of my last grep, core does not include any final classes, but I'm marking this critical because it could cause very odd, confusing blow-ups in contrib if not dealt with. The attached patch fixes the relevant regex.

Comment	File	Size	Author
	final_classes_in_registry.patch	721 bytes	sdboyer

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

grendzy CreditAttribution: grendzy commented 17 September 2010 at 06:06

Status:

Needs review

» Reviewed & tested by the community

makes sense to me.

Comment #2

chx CreditAttribution: chx commented 17 September 2010 at 07:29

Before someone asks, what else can be there here are lines 329-333 from PHP 5.3 grammar:

class_entry_type:
                T_CLASS                 { $$.u.opline_num = CG(zend_lineno); $$.u.EA.type = 0; }
        |       T_ABSTRACT T_CLASS { $$.u.opline_num = CG(zend_lineno); $$.u.EA.type = ZEND_ACC_EXPLICIT_ABSTRACT_CLASS; }
        |       T_FINAL T_CLASS { $$.u.opline_num = CG(zend_lineno); $$.u.EA.type = ZEND_ACC_FINAL_CLASS; }
;

So now we are done. (interfaces can't have any of this)