notice on expired sessions [#91046]

Line 44 of session.inc is

<?php
    $user = drupal_anonymous_user($user->session);
?>

However, in situations where $user->session is not set there is an error thrown ("Trying to get property of non-object"). Because the query to establish $user has failed (as it should), $user is not yet an object. So now we do

<?php
    $session = isset($user->session) ? $user->session : '';
    $user = drupal_anonymous_user($session);
?>

Comment	File	Size	Author
	nosessjv.patch	630 bytes	jvandyk

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

profix898 CreditAttribution: profix898 commented 24 October 2006 at 16:47

Marked http://drupal.org/node/91004 (by stefano73 a few hours ago) as duplicate of this one.

Comment #2

stefano73 CreditAttribution: stefano73 commented 24 October 2006 at 16:52

Why not set $session to session_id() (or $key) when $user->session is not set?

Comment #3

profix898 CreditAttribution: profix898 commented 24 October 2006 at 17:12

I guess, because in function drupal_anonymous_user($session = '') { ..} the default value is '' already!? Does it make any difference? Any advantage setting it to session_id()?

How can spawn a situation where this patch is needed? I tried to truncate the 'session' table but that seems not enough!
I will try to reproduce/review and comment back soon.

Comment #4

profix898 CreditAttribution: profix898 commented 24 October 2006 at 17:59

Status:

Needs review

» Reviewed & tested by the community

"Why not set $session to session_id()"

The content of session is a serialized array of session variables, so it it doesnt make sense to simply store a string.
It doesnt make sense either to store the session id in the session itself. You can always call session_id(), if you need it, not?

To reproduce one needs a session cookie in the browser, otherwise if (!isset($_COOKIE[session_name()])) { $user = drupal_anonymous_user(); ... } simply returns with a (new) 'anonymous' user. The use case of this patch is e.g. when the user session has expired.

Patch is simple and solved the issue.