trying to track down a bug in my install make me read again all the code and i have a little note about it : according to http://drupal.org/node/40684 $node parameter should be passed by reference and not by value in some functions. so :
multichoice_insert(&$node)
multichoice_delete(&$node)
quiz_insert(&$node)
quiz_delete($node) ...
further reading at http://api.drupal.org/api/4.7/function/hook_form and http://api.drupal.org/api/4.7/function/hook_delete

i do not provide a patch (sorry, i'm very busy and a bug in my drupal is driving me to a headhache) :)

CommentFileSizeAuthor
#1 quiz_reference.patch1.98 KBseanbfuller
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

seanbfuller’s picture

Status: Active » Fixed
FileSize
1.98 KB

Passing the node by reference instead of creating a copy is a performance boost, correct? Committed to HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)

  • Commit 2f2b79d on 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x by seanbfuller:
    #90987 Pass $node by reference in several functions.
    
    

  • Commit 2f2b79d on 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages by seanbfuller:
    #90987 Pass $node by reference in several functions.
    
    

  • Commit 2f2b79d on 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages, 2269219 by seanbfuller:
    #90987 Pass $node by reference in several functions.
    
    

  • Commit 2f2b79d on 4.7.x-1.x, 5.x-1.x, 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, 2269219 by seanbfuller:
    #90987 Pass $node by reference in several functions.