Theres a number of redundancies in the maintenance-page.tpl.php - regions that never get printed including $page_top and $page_bottom (not even included in cores maintenance-page.tpl.php).

The conditional logic for the site name is also redundant - maintenance page always have titles afaict.

Also needs a white space cleanup (some redundant extra lines).

CommentFileSizeAuthor
#4 drupal-bartik-903046-4.patch4.92 KBtim.plunkett
bartik-maintenance-page-cleanup.patch4.98 KBJeff Burnz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bleen’s picture

bleen CreditAttribution: bleen commented

I like when there are so many more -'s than +'s :)

why can this be combined into one div? Havent thought this out too much
<div id="header"><div class="section clearfix">

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented

Ah I wish I'd seen this issue before I cleaned up a bit of the markup while doing #790556: Make the Maintenance Page Kick Ass

I'm going to retest it. It might need to be rerolled.

jensimmons’s picture

jensimmons CreditAttribution: jensimmons commented

bartik-maintenance-page-cleanup.patch queued for re-testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
drupal-bartik-903046-4.patch4.92 KB

Reroll!

idflood’s picture

idflood CreditAttribution: idflood commented

Looks ok for me. I really like this patch. Same look and functionality while going from 43 lines down to 27.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Reviewed & tested by the community

Mine really was just a reroll of Jeff's patch, I feel comfortable RTBC-ing this.

bleen’s picture

bleen CreditAttribution: bleen commented

I second...

RTBC++

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks! :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.